Re: [PATCH 12/12] repair: cleanup inode record macros

Mark Tinguely
2012-01-12T17:05:34Z

On 01/11/12 05:30, Christoph Hellwig wrote:
> ping?
>
> On Fri, Dec 02, 2011 at 12:46:31PM -0500, Christoph Hellwig wrote:
>> Remove indirections in the inode record bit manipulation macros and flatten
>> them to a single level of inlines. Also use a common IREC_MASK define
>> instead of duplicating it for every bitmask.
>>
>>
>> Signed-off-by: Christoph Hellwig<hch@lst.de>
>>

Reviewed-by: Mark Tinguely <tinguely@sgi.com>

The clean up looks good. I like the removal of the side effect that was
in one of the ASSERT statement.

--Mark Tinguely