Re: [PATCH 2/2] xfs: cleanup XFS_BB_FSB_OFFSET

Re: [PATCH 2/2] xfs: cleanup XFS_BB_FSB_OFFSET

[Amit Sahrawat]

Courtesy: Dave Chinner


Thanks & Regards,
Amit Sahrawat

On Fri, Jan 6, 2012 at 4:42 PM, Amit Sahrawat <amit.sahrawat83@gmail.com> wrote:
> Removing the macro, as this is no more needed in the code.
> Tried to find the reference when it was last used - but the usage
> for this seemed to have been dropped long time ago.
>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
> ---
>  fs/xfs/xfs_sb.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/xfs/xfs_sb.h b/fs/xfs/xfs_sb.h
> index cb6ae71..f429d9d 100644
> --- a/fs/xfs/xfs_sb.h
> +++ b/fs/xfs/xfs_sb.h
> @@ -529,7 +529,6 @@ static inline int xfs_sb_version_hasprojid32bit(xfs_sb_t *sbp)
>  #define        XFS_BB_TO_FSB(mp,bb)    \
>        (((bb) + (XFS_FSB_TO_BB(mp,1) - 1)) >> (mp)->m_blkbb_log)
>  #define        XFS_BB_TO_FSBT(mp,bb)   ((bb) >> (mp)->m_blkbb_log)
> -#define        XFS_BB_FSB_OFFSET(mp,bb) ((bb) & ((mp)->m_bsize - 1))
>
>  /*
>  * File system block to byte conversions.
> --
> 1.7.2.3
>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 2/2] xfs: cleanup XFS_BB_FSB_OFFSET

[Amit Sahrawat]

Removing the macro, as this is no more needed in the code. 
Tried to find the reference when it was last used - but the usage 
for this seemed to have been dropped long time ago.

Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
---
 fs/xfs/xfs_sb.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/xfs_sb.h b/fs/xfs/xfs_sb.h
index cb6ae71..f429d9d 100644
--- a/fs/xfs/xfs_sb.h
+++ b/fs/xfs/xfs_sb.h
@@ -529,7 +529,6 @@ static inline int xfs_sb_version_hasprojid32bit(xfs_sb_t *sbp)
 #define	XFS_BB_TO_FSB(mp,bb)	\
 	(((bb) + (XFS_FSB_TO_BB(mp,1) - 1)) >> (mp)->m_blkbb_log)
 #define	XFS_BB_TO_FSBT(mp,bb)	((bb) >> (mp)->m_blkbb_log)
-#define	XFS_BB_FSB_OFFSET(mp,bb) ((bb) & ((mp)->m_bsize - 1))
 
 /*
  * File system block to byte conversions.
-- 
1.7.2.3

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 2/2] xfs: cleanup XFS_BB_FSB_OFFSET

[Christoph Hellwig]

On Fri, Jan 06, 2012 at 04:42:18PM +0530, Amit Sahrawat wrote:
> Removing the macro, as this is no more needed in the code. 
> Tried to find the reference when it was last used - but the usage 
> for this seemed to have been dropped long time ago.
> 
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>

This looks good, but the subject should be something like:

"xfs: kill the unused XFS_BB_FSB_OFFSET macro"


Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 2/2] xfs: cleanup XFS_BB_FSB_OFFSET

[Amit Sahrawat]

thanks Christoph,

Resent the patch after the subject change.

Regards,
Amit Sahrawat

On Wed, Jan 11, 2012 at 5:05 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, Jan 06, 2012 at 04:42:18PM +0530, Amit Sahrawat wrote:
>> Removing the macro, as this is no more needed in the code.
>> Tried to find the reference when it was last used - but the usage
>> for this seemed to have been dropped long time ago.
>>
>> Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
>
> This looks good, but the subject should be something like:
>
> "xfs: kill the unused XFS_BB_FSB_OFFSET macro"
>
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs