[PATCH] xfsdump: fix restore of ext attrs on root directory

[PATCH] xfsdump: fix restore of ext attrs on root directory

[Bill Kendall]

xfsrestore fails to restore extended attributes on the root directory
because Node2path(), which returns a pathname relative to the restore
root, returns an empty string instead of ".".

Signed-off-by: Bill Kendall <wkendall@sgi.com>
---
 restore/tree.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/restore/tree.c b/restore/tree.c
index afe7042..bb5df06 100644
--- a/restore/tree.c
+++ b/restore/tree.c
@@ -3450,7 +3450,7 @@ static bool_t
 Node2path( nh_t nh, char *path, char *errmsg )
 {
 	intgen_t remainingcnt;
-	path[ 0 ] = 0; /* in case root node passed in */
+	strcpy(path, "."); /* in case root node passed in */
 	remainingcnt = Node2path_recurse( nh, path, MAXPATHLEN, 0 );
 	if ( remainingcnt <= 0 ) {
 		node_t *np = Node_map( nh );
-- 
1.7.0.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsdump: fix restore of ext attrs on root directory

[Christoph Hellwig]

On Fri, Jan 06, 2012 at 02:51:56PM -0600, Bill Kendall wrote:
> xfsrestore fails to restore extended attributes on the root directory
> because Node2path(), which returns a pathname relative to the restore
> root, returns an empty string instead of ".".
> 
> Signed-off-by: Bill Kendall <wkendall@sgi.com>
> ---
>  restore/tree.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs