From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: Ben Myers <bpm@sgi.com>, Alex Elder <elder@kernel.org>,
stable@kernel.org, Carlos Maiolino <cmaiolino@redhat.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Fix missing xfs_iunlock() on error recovery path in xfs_readlink()
Date: Thu, 12 Jan 2012 07:39:41 +1100 [thread overview]
Message-ID: <20120111203941.GJ24410@dastard> (raw)
In-Reply-To: <1326307930-21251-1-git-send-email-jack@suse.cz>
On Wed, Jan 11, 2012 at 07:52:10PM +0100, Jan Kara wrote:
> Commit b52a360b forgot to call xfs_iunlock() when it detected corrupted
> symplink and bailed out. Fix it by jumping to 'out' instead of doing return.
>
> CC: stable@kernel.org
> CC: Carlos Maiolino <cmaiolino@redhat.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/xfs/xfs_vnodeops.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c
> index f2fea86..6156cd6 100644
> --- a/fs/xfs/xfs_vnodeops.c
> +++ b/fs/xfs/xfs_vnodeops.c
> @@ -131,7 +131,8 @@ xfs_readlink(
> __func__, (unsigned long long) ip->i_ino,
> (long long) pathlen);
> ASSERT(0);
> - return XFS_ERROR(EFSCORRUPTED);
> + error = XFS_ERROR(EFSCORRUPTED);
> + goto out;
> }
Heh, you beat me to it. I was testing an identical patch yesterday
for this problem which was tripped over by RH QA....
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-01-11 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 18:52 [PATCH] xfs: Fix missing xfs_iunlock() on error recovery path in xfs_readlink() Jan Kara
2012-01-11 19:13 ` Ben Myers
2012-01-24 18:01 ` Christoph Hellwig
2012-01-25 16:15 ` Ben Myers
2012-01-11 20:30 ` Alex Elder
2012-01-11 20:39 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111203941.GJ24410@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=cmaiolino@redhat.com \
--cc=elder@kernel.org \
--cc=jack@suse.cz \
--cc=stable@kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox