From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q0CGEFA9005000 for ; Thu, 12 Jan 2012 10:14:15 -0600 Date: Thu, 12 Jan 2012 11:14:10 -0500 From: Christoph Hellwig Subject: Re: [RFC PATCH] xfs: show uuid when mount fails due to duplicate uuid Message-ID: <20120112161410.GA3810@infradead.org> References: <20120112024720.3952.73517.stgit@ltc219.sdl.hitachi.co.jp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120112024720.3952.73517.stgit@ltc219.sdl.hitachi.co.jp> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Mitsuo Hayasaka Cc: Alex Elder , yrl.pp-manager.tt@hitachi.com, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, xfs-masters@oss.sgi.com, Ben Myers , Alex Elder On Thu, Jan 12, 2012 at 11:47:20AM +0900, Mitsuo Hayasaka wrote: > When a system tries to mount a filesystem (FS) using UUID, the xfs > returns -EINVAL and shows a message if a FS with the same UUID has > been already mounted. It is useful to output the duplicate UUID > with it. Looks good to me, Reviewed-by: Christoph Hellwig > - xfs_warn(mp, "Filesystem has duplicate UUID - can't mount"); > + xfs_warn(mp, > + "Filesystem has duplicate UUID - can't mount: uuid = %pU", > + uuid); Maybe we could write this a bit nicer as: xfs_warn(mp, "Filesystem has duplicate UUID %p - can't mount", uuid); _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs