From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: Alex Elder <elder@kernel.org>, Surbhi Palande <csurbhi@gmail.com>,
Kamal Mostafa <kamal@canonical.com>,
Eric Sandeen <sandeen@sandeen.net>,
LKML <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com, Christoph Hellwig <hch@infradead.org>,
Ben Myers <bpm@sgi.com>, Dave Chinner <dchinner@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 4/4] xfs: Protect xfs_file_aio_write() with sb_start_write - sb_end_write
Date: Thu, 12 Jan 2012 21:29:41 +0000 [thread overview]
Message-ID: <20120112212941.GI23916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1326331253-6497-5-git-send-email-jack@suse.cz>
On Thu, Jan 12, 2012 at 02:20:53AM +0100, Jan Kara wrote:
> Replace racy xfs_wait_for_freeze() check with reliable sb_start_write()
> - sb_end_write() locking. Due to lock ranking dictated by the page fault
> code we have to call sb_start_write() after we acquire ilock.
>
> CC: Ben Myers <bpm@sgi.com>
> CC: Alex Elder <elder@kernel.org>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/xfs/xfs_file.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 753ed9b..c5f879b 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -862,9 +862,11 @@ xfs_file_dio_aio_write(
> *iolock = XFS_IOLOCK_SHARED;
> }
>
> + sb_start_write(inode->i_sb);
> trace_xfs_file_direct_write(ip, count, iocb->ki_pos, 0);
> ret = generic_file_direct_write(iocb, iovp,
> &nr_segs, pos, &iocb->ki_pos, count, ocount);
> + sb_end_write(inode->i_sb);
What lock ordering do you have in mind? Explicit description in fs/super.c,
please...
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-01-12 21:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 1:20 [PATCH 0/4] Fix filesystem freezing Jan Kara
2012-01-12 1:20 ` [PATCH 1/4] fs: Improve filesystem freezing handling Jan Kara
2012-01-12 19:53 ` Andreas Dilger
2012-01-12 20:07 ` Jan Kara
2012-01-12 22:57 ` Eric Sandeen
2012-01-12 23:15 ` Jan Kara
2012-01-13 1:26 ` Dave Chinner
2012-01-13 10:12 ` Jan Kara
2012-01-12 1:20 ` [PATCH 2/4] vfs: Protect write paths by sb_start_write - sb_end_write Jan Kara
2012-01-12 19:56 ` Andreas Dilger
2012-01-12 20:11 ` Jan Kara
2012-01-12 1:20 ` [PATCH 3/4] ext4: Protect ext4_page_mkwrite with " Jan Kara
2012-01-12 1:20 ` [PATCH 4/4] xfs: Protect xfs_file_aio_write() " Jan Kara
2012-01-12 21:29 ` Al Viro [this message]
2012-01-12 21:36 ` Jan Kara
2012-01-12 2:48 ` [PATCH 0/4] Fix filesystem freezing Dave Chinner
2012-01-12 11:30 ` Jan Kara
2012-01-13 0:09 ` Dave Chinner
2012-01-13 11:07 ` Jan Kara
2012-01-12 20:48 ` Ted Ts'o
2012-01-12 21:38 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112212941.GI23916@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bpm@sgi.com \
--cc=csurbhi@gmail.com \
--cc=dchinner@redhat.com \
--cc=elder@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=kamal@canonical.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox