From: JiSheng Zhang <jszhang3@mail.ustc.edu.cn>
To: xfs@oss.sgi.com, elder@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] xfs: remove unecessary AIL push wakeups
Date: Fri, 13 Jan 2012 01:30:28 +0800 [thread overview]
Message-ID: <20120113013028.6802d878@ustc> (raw)
In commit 0030807c66("xfs: revert to using a kthread for AIL pushing"),
AIL pushing is revert back to use a kthread. But unfortunately, it
introduced a regression: there are unnecessary AIL push wakeups during
idle, ~20 wakeups/s. This change remove the wakeups by reverting a bit
more: set "tout" value as zero during idle.
Signed-off-by: JiSheng Zhang <jszhang3@mail.ustc.edu.cn>
---
fs/xfs/xfs_trans_ail.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
index ed9252b..2014387 100644
--- a/fs/xfs/xfs_trans_ail.c
+++ b/fs/xfs/xfs_trans_ail.c
@@ -508,7 +508,7 @@ out_done:
ailp->xa_last_pushed_lsn = 0;
ailp->xa_log_flush = 0;
- tout = 50;
+ tout = 0;
} else if (XFS_LSN_CMP(lsn, target) >= 0) {
/*
* We reached the target so wait a bit longer for I/O to
--
1.7.8.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2012-01-12 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 17:30 JiSheng Zhang [this message]
2012-01-24 18:02 ` [PATCH] xfs: remove unecessary AIL push wakeups Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113013028.6802d878@ustc \
--to=jszhang3@mail.ustc.edu.cn \
--cc=elder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox