Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks

Christoph Hellwig
2011-12-14T14:26:47Z

On Wed, Dec 14, 2011 at 10:20:17AM +1100, Dave Chinner wrote:
> On Thu, Dec 08, 2011 at 10:58:05AM -0500, Christoph Hellwig wrote:
> > While xfs_iunlock is fine with 0 lockflags the calling conventions are much
> > cleaner if xfs_file_aio_write_checks never returns without the iolock held.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> I'm not sure this makes sense by itself. maybe combine it with the
> next patch? Regardless:

I actually had it that way initially but split the patches because the
changes aren't directly related.