From: Christoph Hellwig <hch@infradead.org>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC PATCH 1/4] Define a new function xfs_this_quota_on()
Date: Tue, 24 Jan 2012 12:47:12 -0500 [thread overview]
Message-ID: <20120124174712.GD9853@infradead.org> (raw)
In-Reply-To: <20120123173125.31546.2342.sendpatchset@chandra-lucid.austin.ibm.com>
On Mon, Jan 23, 2012 at 11:31:25AM -0600, Chandra Seetharaman wrote:
> Create a new function xfs_this_quota_on() that takes a xfs_mount
> data srtucture and a disk quota type and returns true if the specified
> type of quota is ON in the xfs_mount data structure.
>
> Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
Looks good except for a tiny style nitpick.
Reviewed-by: Christoph Hellwig <hch@lst.de>
> + switch(type) {
This should have a whitespace after the opening brace.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-01-24 17:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 17:31 [RFC PATCH 0/4] Rearrange code to make the code more readable Chandra Seetharaman
2012-01-23 17:31 ` [RFC PATCH 1/4] Define a new function xfs_this_quota_on() Chandra Seetharaman
2012-01-24 17:47 ` Christoph Hellwig [this message]
2012-02-03 15:19 ` Ben Myers
2012-01-23 17:31 ` [RFC PATCH 2/4] Define a new function xfs_inode_dquot() Chandra Seetharaman
2012-01-24 17:48 ` Christoph Hellwig
2012-01-24 19:41 ` Chandra Seetharaman
2012-02-03 16:21 ` Ben Myers
2012-01-23 17:31 ` [RFC PATCH 3/4] Change xfs_sb_from_disk() interface to take a mount pointer Chandra Seetharaman
2012-01-24 17:52 ` Christoph Hellwig
2012-02-03 17:02 ` Ben Myers
2012-01-23 17:31 ` [RFC PATCH 4/4] Define new macro XFS_ALL_QUOTA_ACTIVE and simply some usage Chandra Seetharaman
2012-01-24 17:53 ` Christoph Hellwig
2012-02-03 17:16 ` Ben Myers
-- strict thread matches above, loose matches on Subject: below --
2011-10-27 22:05 [RFC PATCH 0/4] Rearrange code to make the code more readable Chandra Seetharaman
2011-10-27 22:05 ` [RFC PATCH 1/4] Define a new function xfs_this_quota_on() Chandra Seetharaman
2011-10-27 22:24 ` Christoph Hellwig
2011-11-11 20:29 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124174712.GD9853@infradead.org \
--to=hch@infradead.org \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox