From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: James Lawrie <james@jdlawrie.co.uk>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: check for size parsing errors in xfs_quota
Date: Tue, 24 Jan 2012 12:56:12 -0500 [thread overview]
Message-ID: <20120124175612.GH9853@infradead.org> (raw)
In-Reply-To: <4F1D9989.8060808@redhat.com>
> - v = (__uint64_t)cvtnum(blocksize, sectorsize, s);
> - *value = v >> 9; /* syscalls use basic blocks */
> + v = cvtnum(blocksize, sectorsize, s);
> + if (v == -1LL) {
> + fprintf(stderr, _("%s: Error: could not parse size %s.\n"), progname, s);
> + return 0;
> + }
> + *value = (__uint64_t)v >> 8; /* syscalls use basic blocks */
Why do you replace the shift by nine with a shift by 8?
Also please don't introduce new overly long lines, just move the
translated string to a line of its own, indented by a single tab similar
to how we do it in most new xfs/xfsprogs code.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-01-24 17:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 17:31 [PATCH] xfsprogs: check for size parsing errors in xfs_quota Eric Sandeen
2012-01-23 19:59 ` Christoph Hellwig
2012-01-24 5:07 ` Eric Sandeen
2012-01-24 17:56 ` Christoph Hellwig [this message]
2012-01-24 17:58 ` Eric Sandeen
2012-01-27 19:26 ` [PATCH V2] " Eric Sandeen
2012-02-03 17:41 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124175612.GH9853@infradead.org \
--to=hch@infradead.org \
--cc=james@jdlawrie.co.uk \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox