From: Christoph Hellwig <hch@infradead.org>
To: JiSheng Zhang <jszhang3@mail.ustc.edu.cn>
Cc: elder@kernel.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: remove unecessary AIL push wakeups
Date: Tue, 24 Jan 2012 13:02:15 -0500 [thread overview]
Message-ID: <20120124180215.GC23671@infradead.org> (raw)
In-Reply-To: <20120113013028.6802d878@ustc>
On Fri, Jan 13, 2012 at 01:30:28AM +0800, JiSheng Zhang wrote:
>
> In commit 0030807c66("xfs: revert to using a kthread for AIL pushing"),
> AIL pushing is revert back to use a kthread. But unfortunately, it
> introduced a regression: there are unnecessary AIL push wakeups during
> idle, ~20 wakeups/s. This change remove the wakeups by reverting a bit
> more: set "tout" value as zero during idle.
>
> Signed-off-by: JiSheng Zhang <jszhang3@mail.ustc.edu.cn>
Looks fine, although I'm a bit worried that I don't have the setup to
reproduce the issue that the patch addressed any more and we might
regress here.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-01-24 18:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 17:30 [PATCH] xfs: remove unecessary AIL push wakeups JiSheng Zhang
2012-01-24 18:02 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124180215.GC23671@infradead.org \
--to=hch@infradead.org \
--cc=elder@kernel.org \
--cc=jszhang3@mail.ustc.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox