From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q0SAt3oF107107 for ; Sat, 28 Jan 2012 04:55:03 -0600 Date: Sat, 28 Jan 2012 13:55:01 +0300 From: Dan Carpenter Subject: [patch] xfs: remove an unneeded NULL check Message-ID: <20120128105501.GB25092@elgon.mountain> MIME-Version: 1.0 Content-Disposition: inline List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Ben Myers Cc: xfs-masters@oss.sgi.com, Alex Elder , kernel-janitors@vger.kernel.org, xfs@oss.sgi.com Smatch complains because we check "commit_lsn" for NULL inconsistently. fs/xfs/xfs_log_cil.c +705 xfs_log_commit_cil(43) error: we previously assumed 'commit_lsn' could be null (see line 688) xfs_log_commit_cil() is only called from one place, and "commit_lsn" is a valid pointer, so I've removed the NULL check. Signed-off-by: Dan Carpenter diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c index d4fadbe..d9c4652 100644 --- a/fs/xfs/xfs_log_cil.c +++ b/fs/xfs/xfs_log_cil.c @@ -685,8 +685,7 @@ xfs_log_commit_cil( /* lock out background commit */ down_read(&log->l_cilp->xc_ctx_lock); - if (commit_lsn) - *commit_lsn = log->l_cilp->xc_ctx->sequence; + *commit_lsn = log->l_cilp->xc_ctx->sequence; xlog_cil_insert_items(log, log_vector, tp->t_ticket); _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs