From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q11Aj6Ct239807 for ; Wed, 1 Feb 2012 04:45:07 -0600 Date: Wed, 1 Feb 2012 05:45:01 -0500 From: Christoph Hellwig Subject: Re: [patch] xfs: remove an unneeded NULL check Message-ID: <20120201104500.GA13672@infradead.org> References: <20120128105501.GB25092@elgon.mountain> <20120131225601.GQ9090@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120131225601.GQ9090@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: Alex Elder , kernel-janitors@vger.kernel.org, xfs@oss.sgi.com, xfs-masters@oss.sgi.com, Ben Myers , Dan Carpenter On Wed, Feb 01, 2012 at 09:56:01AM +1100, Dave Chinner wrote: > > /* lock out background commit */ > > down_read(&log->l_cilp->xc_ctx_lock); > > - if (commit_lsn) > > - *commit_lsn = log->l_cilp->xc_ctx->sequence; > > + *commit_lsn = log->l_cilp->xc_ctx->sequence; > > > > xlog_cil_insert_items(log, log_vector, tp->t_ticket); > > There's a set of reviewed patches (for 3.3) that change all this > code. The null check might still be there, but that needs to be > checked. Which series is that? I mut have to admit I've lost track by now. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs