From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q11LDVuL009507 for ; Wed, 1 Feb 2012 15:13:31 -0600 Date: Thu, 2 Feb 2012 08:13:26 +1100 From: Dave Chinner Subject: Re: [patch] xfs: remove an unneeded NULL check Message-ID: <20120201211326.GU9090@dastard> References: <20120128105501.GB25092@elgon.mountain> <20120131225601.GQ9090@dastard> <20120201104500.GA13672@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120201104500.GA13672@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: Alex Elder , kernel-janitors@vger.kernel.org, xfs@oss.sgi.com, xfs-masters@oss.sgi.com, Ben Myers , Dan Carpenter On Wed, Feb 01, 2012 at 05:45:01AM -0500, Christoph Hellwig wrote: > On Wed, Feb 01, 2012 at 09:56:01AM +1100, Dave Chinner wrote: > > > /* lock out background commit */ > > > down_read(&log->l_cilp->xc_ctx_lock); > > > - if (commit_lsn) > > > - *commit_lsn = log->l_cilp->xc_ctx->sequence; > > > + *commit_lsn = log->l_cilp->xc_ctx->sequence; > > > > > > xlog_cil_insert_items(log, log_vector, tp->t_ticket); > > > > There's a set of reviewed patches (for 3.3) that change all this > > code. The null check might still be there, but that needs to be > > checked. > > Which series is that? I mut have to admit I've lost track by now. The removal of all the old log code. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs