From: Brian Candler <B.Candler@pobox.com>
To: xfs@oss.sgi.com
Subject: Trailing garbage in event tracing output
Date: Thu, 2 Feb 2012 11:52:11 +0000 [thread overview]
Message-ID: <20120202115211.GA1259@nsrc.org> (raw)
Just a minor issue, but when I did some XFS tracing using the instructions
at http://lwn.net/Articles/341899/ I found that there was trailing garbage
in the filenames logged in xfs_lookup. Example:
...
bonnie++-26179 [000] 322388.834204: xfs_iunlock: dev 8:32 ino 0xfe1e6 flags ILOCK_SHARED caller xfs_free_eofblocks
bonnie++-26179 [000] 322388.834212: xfs_lookup: dev 8:32 dp ino 0xfb50d name 000000295aSl688>v??*N
bonnie++-26179 [000] 322388.834213: xfs_ilock: dev 8:32 ino 0xfb50d flags ILOCK_SHARED caller xfs_ilock_map_shared
...
(where I think the real filename was "000000295aSl688"). I would guess the
logger is expecting null-terminated strings but they aren't.
This is with the stock kernel from Ubuntu 11.10 server x86_64:
Linux storage1 3.0.0-15-server #26-Ubuntu SMP Fri Jan 20 19:07:39 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
Regards,
Brian.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2012-02-02 11:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 11:52 Brian Candler [this message]
2012-02-02 14:09 ` Trailing garbage in event tracing output Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202115211.GA1259@nsrc.org \
--to=b.candler@pobox.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox