From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: jack@suse.cz, xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] quota: make Q_XQUOTASYNC a noop
Date: Thu, 2 Feb 2012 19:06:26 +0100 [thread overview]
Message-ID: <20120202180626.GA7494@quack.suse.cz> (raw)
In-Reply-To: <20120202161629.559449485@bombadil.infradead.org>
On Thu 02-02-12 11:14:12, Christoph Hellwig wrote:
> Now that XFS takes quota reservations into account there is no need to flush
> anything before reporting quotas - in addition to beeing fully transactional
> all quota information is also 100% coherent with the rest of the filesystem
> now.
Looks fine. You can add:
Acked-by: Jan Kara <jack@suse.cz>
Honza
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/quota/quota.c
> ===================================================================
> --- xfs.orig/fs/quota/quota.c 2012-02-02 13:06:30.693396524 +0100
> +++ xfs/fs/quota/quota.c 2012-02-02 13:23:23.181244741 +0100
> @@ -282,10 +282,9 @@ static int do_quotactl(struct super_bloc
> case Q_XGETQUOTA:
> return quota_getxquota(sb, type, id, addr);
> case Q_XQUOTASYNC:
> - /* caller already holds s_umount */
> if (sb->s_flags & MS_RDONLY)
> return -EROFS;
> - writeback_inodes_sb(sb, WB_REASON_SYNC);
> + /* XFS quotas are fully coherent now, making this call a noop */
> return 0;
> default:
> return -EINVAL;
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-02 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 16:14 [PATCH 0/3] include reservations in quota reporting Christoph Hellwig
2012-02-02 16:14 ` [PATCH 1/3] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota Christoph Hellwig
2012-02-02 16:14 ` [PATCH 2/3] xfs: include reservations in quota reporting Christoph Hellwig
2012-02-02 16:14 ` [PATCH 3/3] quota: make Q_XQUOTASYNC a noop Christoph Hellwig
2012-02-02 18:06 ` Jan Kara [this message]
2012-02-02 18:07 ` [PATCH 0/3] include reservations in quota reporting Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202180626.GA7494@quack.suse.cz \
--to=jack@suse.cz \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox