public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] xfsprogs: add debian linux-libc-dev build dependency
       [not found] <1317955640.69734.1328051152460.JavaMail.root@acxmail-au2.aconex.com>
@ 2012-01-31 23:07 ` Nathan Scott
  2012-02-02 11:35   ` Christoph Hellwig
  2012-02-02 22:51   ` Dave Chinner
  0 siblings, 2 replies; 3+ messages in thread
From: Nathan Scott @ 2012-01-31 23:07 UTC (permalink / raw)
  To: xfs

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

Add a build dependency on linux-libc-dev, to ensure we build
packages with have_fiemap set to true if the headers support
it.  Noticed by Dave, some package builds didn't enable this
when they should have.

Signed-off-by: Nathan Scott <nathans@debian.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: debiandeps.patch --]
[-- Type: text/x-patch; name=debiandeps.patch, Size: 673 bytes --]

diff --git a/debian/control b/debian/control
index ca517ad..502b48b 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: admin
 Priority: optional
 Maintainer: XFS Development Team <xfs@oss.sgi.com>
 Uploaders: Nathan Scott <nathans@debian.org>, Anibal Monsalve Salazar <anibal@debian.org>
-Build-Depends: uuid-dev, autoconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev | libreadline5-dev, libblkid-dev (>= 2.17)
+Build-Depends: uuid-dev, autoconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev | libreadline5-dev, libblkid-dev (>= 2.17), linux-libc-dev
 Standards-Version: 3.9.1
 Homepage: http://oss.sgi.com/projects/xfs/
 

[-- Attachment #3: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [patch] xfsprogs: add debian linux-libc-dev build dependency
  2012-01-31 23:07 ` [patch] xfsprogs: add debian linux-libc-dev build dependency Nathan Scott
@ 2012-02-02 11:35   ` Christoph Hellwig
  2012-02-02 22:51   ` Dave Chinner
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2012-02-02 11:35 UTC (permalink / raw)
  To: Nathan Scott; +Cc: xfs

On Wed, Feb 01, 2012 at 10:07:08AM +1100, Nathan Scott wrote:
> Add a build dependency on linux-libc-dev, to ensure we build
> packages with have_fiemap set to true if the headers support
> it.  Noticed by Dave, some package builds didn't enable this
> when they should have.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] xfsprogs: add debian linux-libc-dev build dependency
  2012-01-31 23:07 ` [patch] xfsprogs: add debian linux-libc-dev build dependency Nathan Scott
  2012-02-02 11:35   ` Christoph Hellwig
@ 2012-02-02 22:51   ` Dave Chinner
  1 sibling, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2012-02-02 22:51 UTC (permalink / raw)
  To: Nathan Scott; +Cc: xfs

On Wed, Feb 01, 2012 at 10:07:08AM +1100, Nathan Scott wrote:
> Add a build dependency on linux-libc-dev, to ensure we build
> packages with have_fiemap set to true if the headers support
> it.  Noticed by Dave, some package builds didn't enable this
> when they should have.
> 
> Signed-off-by: Nathan Scott <nathans@debian.org>

Works for me.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-02-02 22:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1317955640.69734.1328051152460.JavaMail.root@acxmail-au2.aconex.com>
2012-01-31 23:07 ` [patch] xfsprogs: add debian linux-libc-dev build dependency Nathan Scott
2012-02-02 11:35   ` Christoph Hellwig
2012-02-02 22:51   ` Dave Chinner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox