* [patch] xfsprogs: extend fiemap configure check [not found] <519369070.69746.1328051417713.JavaMail.root@acxmail-au2.aconex.com> @ 2012-01-31 23:11 ` Nathan Scott 2012-02-02 11:36 ` Christoph Hellwig 2012-02-02 22:52 ` Dave Chinner 0 siblings, 2 replies; 3+ messages in thread From: Nathan Scott @ 2012-01-31 23:11 UTC (permalink / raw) To: xfs [-- Attachment #1: Type: text/plain, Size: 265 bytes --] Make the fiemap configure check consistent with the other libc interface checks - perform a compile and link with a complete set of symbols, macros and interfaces needed, as opposed to a build with just the headers. Signed-off-by: Nathan Scott <nathans@debian.org> [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: fiemap.patch --] [-- Type: text/x-patch; name=fiemap.patch, Size: 721 bytes --] diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4 index 8192181..1e2c256 100644 --- a/m4/package_libcdev.m4 +++ b/m4/package_libcdev.m4 @@ -121,6 +121,17 @@ AC_DEFUN([AC_HAVE_FALLOCATE], # Check if we have the fiemap ioctl (Linux) # AC_DEFUN([AC_HAVE_FIEMAP], - [ AC_CHECK_HEADERS([linux/fiemap.h], [ have_fiemap=yes ], [ have_fiemap=no ]) + [ AC_MSG_CHECKING([for fiemap]) + AC_TRY_LINK([ +#define _GNU_SOURCE +#define _FILE_OFFSET_BITS 64 +#include <linux/fs.h> +#include <linux/fiemap.h> + ], [ + struct fiemap *fiemap; + ioctl(0, FS_IOC_FIEMAP, (unsigned long)fiemap); + ], have_fiemap=yes + AC_MSG_RESULT(yes), + AC_MSG_RESULT(no)) AC_SUBST(have_fiemap) ]) [-- Attachment #3: Type: text/plain, Size: 121 bytes --] _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] xfsprogs: extend fiemap configure check 2012-01-31 23:11 ` [patch] xfsprogs: extend fiemap configure check Nathan Scott @ 2012-02-02 11:36 ` Christoph Hellwig 2012-02-02 22:52 ` Dave Chinner 1 sibling, 0 replies; 3+ messages in thread From: Christoph Hellwig @ 2012-02-02 11:36 UTC (permalink / raw) To: Nathan Scott; +Cc: xfs On Wed, Feb 01, 2012 at 10:11:16AM +1100, Nathan Scott wrote: > Make the fiemap configure check consistent with the other > libc interface checks - perform a compile and link with a > complete set of symbols, macros and interfaces needed, as > opposed to a build with just the headers. > > Signed-off-by: Nathan Scott <nathans@debian.org> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de> _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] xfsprogs: extend fiemap configure check 2012-01-31 23:11 ` [patch] xfsprogs: extend fiemap configure check Nathan Scott 2012-02-02 11:36 ` Christoph Hellwig @ 2012-02-02 22:52 ` Dave Chinner 1 sibling, 0 replies; 3+ messages in thread From: Dave Chinner @ 2012-02-02 22:52 UTC (permalink / raw) To: Nathan Scott; +Cc: xfs On Wed, Feb 01, 2012 at 10:11:16AM +1100, Nathan Scott wrote: > Make the fiemap configure check consistent with the other > libc interface checks - perform a compile and link with a > complete set of symbols, macros and interfaces needed, as > opposed to a build with just the headers. > > Signed-off-by: Nathan Scott <nathans@debian.org> Definitely a good idea. Reviewed-by: Dave Chinner <dchinner@redhat.com> -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-02 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <519369070.69746.1328051417713.JavaMail.root@acxmail-au2.aconex.com>
2012-01-31 23:11 ` [patch] xfsprogs: extend fiemap configure check Nathan Scott
2012-02-02 11:36 ` Christoph Hellwig
2012-02-02 22:52 ` Dave Chinner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox