From: Ben Myers <bpm@sgi.com>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [RFC PATCH 2/4] Define a new function xfs_inode_dquot()
Date: Fri, 3 Feb 2012 10:21:34 -0600 [thread overview]
Message-ID: <20120203162134.GI13095@sgi.com> (raw)
In-Reply-To: <1327434096.2213.18.camel@chandra-lucid.austin.ibm.com>
Hey Chandra,
On Tue, Jan 24, 2012 at 01:41:36PM -0600, Chandra Seetharaman wrote:
> On Tue, 2012-01-24 at 12:48 -0500, Christoph Hellwig wrote:
> > On Mon, Jan 23, 2012 at 11:31:30AM -0600, Chandra Seetharaman wrote:
> > > Define a new function xfs_inode_dquot() that takes a inode pointer
> > > and a disk quota type and returns the quota pointer for the specified
> > > quota type.
> > >
> > > This simplifies the xfs_qm_dqget() error path significantly.
> >
> > Looks good,
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> >
> > > +static inline xfs_dquot_t *xfs_inode_dquot(struct xfs_inode *ip, int type)
> > > +{
> > > + type &= XFS_DQ_ALLTYPES;
> > > + switch(type) {
> >
> > Same style nitpick as for the last patch.
> >
> > Btw, instead of masking out XFS_DQ_ALLTYPES first this would be more
> > readable as:
> >
> > switch (type & XFS_DQ_ALLTYPES) {
> >
> > (that also applies to the previous patch).
> >
>
> Will fix both of these in the next version.
I'll fix them up. No need to post again. I also twiddled the order of
USER/GROUP/PROJ in xfs_inode_dquot to match xfs_this_quota_on.
Looks good.
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-03 16:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 17:31 [RFC PATCH 0/4] Rearrange code to make the code more readable Chandra Seetharaman
2012-01-23 17:31 ` [RFC PATCH 1/4] Define a new function xfs_this_quota_on() Chandra Seetharaman
2012-01-24 17:47 ` Christoph Hellwig
2012-02-03 15:19 ` Ben Myers
2012-01-23 17:31 ` [RFC PATCH 2/4] Define a new function xfs_inode_dquot() Chandra Seetharaman
2012-01-24 17:48 ` Christoph Hellwig
2012-01-24 19:41 ` Chandra Seetharaman
2012-02-03 16:21 ` Ben Myers [this message]
2012-01-23 17:31 ` [RFC PATCH 3/4] Change xfs_sb_from_disk() interface to take a mount pointer Chandra Seetharaman
2012-01-24 17:52 ` Christoph Hellwig
2012-02-03 17:02 ` Ben Myers
2012-01-23 17:31 ` [RFC PATCH 4/4] Define new macro XFS_ALL_QUOTA_ACTIVE and simply some usage Chandra Seetharaman
2012-01-24 17:53 ` Christoph Hellwig
2012-02-03 17:16 ` Ben Myers
-- strict thread matches above, loose matches on Subject: below --
2011-10-27 22:05 [RFC PATCH 0/4] Rearrange code to make the code more readable Chandra Seetharaman
2011-10-27 22:05 ` [RFC PATCH 2/4] Define a new function xfs_inode_dquot() Chandra Seetharaman
2011-11-11 20:29 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120203162134.GI13095@sgi.com \
--to=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox