Re: [RFC PATCH 1/4] Define a new function xfs_this_quota_on()

Ben Myers
2012-02-03T15:19:57Z

On Tue, Jan 24, 2012 at 12:47:12PM -0500, Christoph Hellwig wrote:
> On Mon, Jan 23, 2012 at 11:31:25AM -0600, Chandra Seetharaman wrote:
> > Create a new function xfs_this_quota_on() that takes a xfs_mount
> > data srtucture and a disk quota type and returns true if the specified
> > type of quota is ON in the xfs_mount data structure.
> >
> > Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
>
> Looks good except for a tiny style nitpick.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> > + switch(type) {
>
> This should have a whitespace after the opening brace.

I've added the space.

This patch looks good.

Reviewed-by: Ben Myers <bpm@sgi.com>