[PATCH] xfstests: fsstress - make sync a write op

[PATCH] xfstests: fsstress - make sync a write op

[Eric Sandeen]

I was running 068 to test freeze changes, and realized that
"sync" is not in the op list when "-w" (write ops) is specified,
although fsync & fdatasync are.  It seems to me that sync should
be a default write op as well.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index 9b3af17..738843d 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -178,6 +178,7 @@ void	unresvsp_f(int, long);
 void	write_f(int, long);
 
 opdesc_t	ops[] = {
+     /* { OP_ENUM, "name", function, freq, iswrite }, */
 	{ OP_ALLOCSP, "allocsp", allocsp_f, 1, 1 },
 	{ OP_ATTR_REMOVE, "attr_remove", attr_remove_f, /* 1 */ 0, 1 },
 	{ OP_ATTR_SET, "attr_set", attr_set_f, /* 2 */ 0, 1 },
@@ -207,7 +208,7 @@ opdesc_t	ops[] = {
 	{ OP_SETXATTR, "setxattr", setxattr_f, 1, 1 },
 	{ OP_STAT, "stat", stat_f, 1, 0 },
 	{ OP_SYMLINK, "symlink", symlink_f, 2, 1 },
-	{ OP_SYNC, "sync", sync_f, 1, 0 },
+	{ OP_SYNC, "sync", sync_f, 1, 1 },
 	{ OP_TRUNCATE, "truncate", truncate_f, 2, 1 },
 	{ OP_UNLINK, "unlink", unlink_f, 1, 1 },
 	{ OP_UNRESVSP, "unresvsp", unresvsp_f, 1, 1 },


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: fsstress - make sync a write op

[Dave Chinner]

On Sat, Feb 04, 2012 at 11:15:31AM -0600, Eric Sandeen wrote:
> I was running 068 to test freeze changes, and realized that
> "sync" is not in the op list when "-w" (write ops) is specified,
> although fsync & fdatasync are.  It seems to me that sync should
> be a default write op as well.
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Definitely seems to be an oversight.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs