From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q184Dvi4032723 for ; Tue, 7 Feb 2012 22:13:58 -0600 Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id vLJW1kojOhaX471F for ; Tue, 07 Feb 2012 20:13:55 -0800 (PST) Date: Wed, 8 Feb 2012 15:13:53 +1100 From: Dave Chinner Subject: Re: [PATCH] repair: fix incorrect use of thread local data in dir and attr code Message-ID: <20120208041353.GC20305@dastard> References: <20120207175400.GA24301@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120207175400.GA24301@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Tue, Feb 07, 2012 at 12:54:00PM -0500, Christoph Hellwig wrote: > The attribute and dirv1 code use pthread thread local data incorrectly in > a few places, which will make them fail in horrible ways when using the > ag_stride options. > > Replace the use of thread local data with simple local allocations given > that there is no needed to micro-optimize these allocations as much > as e.g. the extent map. The added benefit is that we have to allocate > less memory, and can free it quickly. > > Reported-by: Tom Crane > Tested-by: Tom Crane > Signed-off-by: Christoph Hellwig Looks pretty sane to me. Especially as the comments suggest it never even worked correctly in the first place. Reviewed-by: Dave Chinner Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs