[PATCH] xfstests: 068: run fsstress in read/write mode

[PATCH] xfstests: 068: run fsstress in read/write mode

[Eric Sandeen]

Jan Kara was testing filesystem freeze, and was consistently locking
up, although my tests of 068 were passing.  He pointed out that
he was running in read/write mode, and it was atime updates causing
the trouble.  Sure enough, dropping "-w" from fsstress locked me up
too.  Change this so we get better (and more realistic) coverage.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
cc: Jan Kara <jack@suse.cz>
---


diff --git a/068 b/068
index 6f08f18..b15409e 100755
--- a/068
+++ b/068
@@ -79,8 +79,9 @@ touch $tmp.running
     nops=200
     while [ -f "$tmp.running" ]
       do
-      #	-w ensures that the only ops are ones which cause write I/O
-      $FSSTRESS_PROG -d $STRESS_DIR -w -p $procs -n $nops $FSSTRESS_AVOID \
+      # We do both read & write IO - not only is this more realistic,
+      # but it also potentially tests atime updates
+      $FSSTRESS_PROG -d $STRESS_DIR -p $procs -n $nops $FSSTRESS_AVOID \
 	  > /dev/null 2>&1
     done
 


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: 068: run fsstress in read/write mode

[Dave Chinner]

On Tue, Feb 07, 2012 at 11:29:44AM -0600, Eric Sandeen wrote:
> Jan Kara was testing filesystem freeze, and was consistently locking
> up, although my tests of 068 were passing.  He pointed out that
> he was running in read/write mode, and it was atime updates causing
> the trouble.  Sure enough, dropping "-w" from fsstress locked me up
> too.  Change this so we get better (and more realistic) coverage.

Good idea.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs