From: Christoph Hellwig <hch@infradead.org>
To: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
Cc: Alex Elder <elder@kernel.org>,
yrl.pp-manager.tt@hitachi.com, linux-kernel@vger.kernel.org,
xfs@oss.sgi.com, xfs-masters@oss.sgi.com, Ben Myers <bpm@sgi.com>,
Alex Elder <aelder@sgi.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH -v2 3/3] xfs: cleanup quota check on disk blocks and inodes reservations
Date: Tue, 14 Feb 2012 21:33:06 -0500 [thread overview]
Message-ID: <20120215023306.GC17149@infradead.org> (raw)
In-Reply-To: <20120206125105.12624.93123.stgit@ltc219.sdl.hitachi.co.jp>
On Mon, Feb 06, 2012 at 09:51:05PM +0900, Mitsuo Hayasaka wrote:
> This patch is a cleanup of quota check on disk blocks and inodes
> reservations, and changes it as follows.
>
> (1) add a total_count variable to store the total number of
> current usages and new reservations for disk blocks and inodes,
> respectively.
>
> (2) make it more readable to check if the local variables softlimit
> and hardlimit are positive. It has been changed as follows.
> if (softlimit > 0ULL) -> if (softlimit)
> if (hardlimit > 0ULL) -> if (hardlimit)
> This is because they are defined as xfs_qcnt_t which is unsigned.
>
> Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
> Cc: Ben Myers <bpm@sgi.com>
> Cc: Alex Elder <elder@kernel.org>
> Cc: Christoph Hellwig <hch@lst.de>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-02-15 2:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 12:49 [PATCH -v2 0/3] xfs: change available ranges in quota check Mitsuo Hayasaka
2012-02-06 12:50 ` [PATCH -v2 1/3] xfs: change available ranges of softlimit and hardlimit " Mitsuo Hayasaka
2012-02-10 20:37 ` Mark Tinguely
2012-02-17 14:01 ` Mark Tinguely
2012-02-15 2:32 ` Christoph Hellwig
2012-02-06 12:50 ` [PATCH -v2 2/3] xfs: make inode quota check more general Mitsuo Hayasaka
2012-02-10 21:32 ` Mark Tinguely
2012-02-15 2:32 ` Christoph Hellwig
2012-02-06 12:51 ` [PATCH -v2 3/3] xfs: cleanup quota check on disk blocks and inodes reservations Mitsuo Hayasaka
2012-02-10 22:23 ` Mark Tinguely
2012-02-15 2:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215023306.GC17149@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=bpm@sgi.com \
--cc=elder@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mitsuo.hayasaka.hu@hitachi.com \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox