From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q1F2X8ni142676 for ; Tue, 14 Feb 2012 20:33:08 -0600 Date: Tue, 14 Feb 2012 21:33:06 -0500 From: Christoph Hellwig Subject: Re: [PATCH -v2 3/3] xfs: cleanup quota check on disk blocks and inodes reservations Message-ID: <20120215023306.GC17149@infradead.org> References: <20120206124951.12624.88233.stgit@ltc219.sdl.hitachi.co.jp> <20120206125105.12624.93123.stgit@ltc219.sdl.hitachi.co.jp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120206125105.12624.93123.stgit@ltc219.sdl.hitachi.co.jp> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Mitsuo Hayasaka Cc: Alex Elder , yrl.pp-manager.tt@hitachi.com, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, xfs-masters@oss.sgi.com, Ben Myers , Alex Elder , Christoph Hellwig On Mon, Feb 06, 2012 at 09:51:05PM +0900, Mitsuo Hayasaka wrote: > This patch is a cleanup of quota check on disk blocks and inodes > reservations, and changes it as follows. > > (1) add a total_count variable to store the total number of > current usages and new reservations for disk blocks and inodes, > respectively. > > (2) make it more readable to check if the local variables softlimit > and hardlimit are positive. It has been changed as follows. > if (softlimit > 0ULL) -> if (softlimit) > if (hardlimit > 0ULL) -> if (hardlimit) > This is because they are defined as xfs_qcnt_t which is unsigned. > > Signed-off-by: Mitsuo Hayasaka > Cc: Ben Myers > Cc: Alex Elder > Cc: Christoph Hellwig Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs