From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/9] xfs: user per-cpu stats for the total dquot numbers
Date: Thu, 16 Feb 2012 11:02:43 +1100 [thread overview]
Message-ID: <20120216000243.GQ14132@dastard> (raw)
In-Reply-To: <20120215023147.612027782@bombadil.infradead.org>
On Tue, Feb 14, 2012 at 09:29:31PM -0500, Christoph Hellwig wrote:
> Switch the total number of dquots counter over to use the per-cpu stats
> implementation, and reintroduce the number of unused dquots counter
> dropped earlier in the series.
>
> Btw, I wonder if we should simply add these counters to /proc/fs/xfs/xqmstat
> instead of keeping the odd format and mostly superflous /proc/fs/xfs/xqm
> around.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> ---
> fs/xfs/xfs_dquot.c | 7 ++++---
> fs/xfs/xfs_qm.c | 3 ++-
> fs/xfs/xfs_qm.h | 1 -
> fs/xfs/xfs_qm_stats.c | 4 ++--
> fs/xfs/xfs_qm_stats.h | 5 +++++
> 5 files changed, 13 insertions(+), 7 deletions(-)
>
> Index: xfs/fs/xfs/xfs_qm_stats.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_qm_stats.c 2012-02-12 13:22:45.040270187 -0800
> +++ xfs/fs/xfs/xfs_qm_stats.c 2012-02-12 13:22:49.553603603 -0800
> @@ -52,9 +52,9 @@ static int xqm_proc_show(struct seq_file
> /* maximum; incore; ratio free to inuse; freelist */
> seq_printf(m, "%d\t%d\t%d\t%u\n",
> 0,
> - xfs_Gqm? atomic_read(&xfs_Gqm->qm_totaldquots) : 0,
> + xqmstats_sum(XQMSTAT_END_XQMSTAT),
> 0,
> - 0);
> + xqmstats_sum(XQMSTAT_END_XQMSTAT + 1));
> return 0;
> }
>
> Index: xfs/fs/xfs/xfs_qm_stats.h
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_qm_stats.h 2012-02-12 13:22:45.040270187 -0800
> +++ xfs/fs/xfs/xfs_qm_stats.h 2012-02-12 13:22:49.553603603 -0800
> @@ -33,6 +33,9 @@ struct xqmstats {
> __uint32_t xs_qm_dqshake_reclaims;
> __uint32_t xs_qm_dqinact_reclaims;
> #define XQMSTAT_END_XQMSTAT 8
> + __uint32_t xs_qm_dquots;
> + __uint32_t xs_qm_dquots_unused;
> +#define XQMSTAT_END_XQM (XQMSTAT_END_XQMSTAT + 4)
Shouldn't that be (XQMSTAT_END_XQMSTAT + 2)?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-16 0:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 2:29 [PATCH 0/9] quota updates V2 Christoph Hellwig
2012-02-15 2:29 ` [PATCH 1/9] xfs: use per-filesystem dquot LRU lists Christoph Hellwig
2012-02-15 22:10 ` Dave Chinner
2012-02-17 17:33 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 2/9] xfs: use per-filesystem radix trees for dquot lookup Christoph Hellwig
2012-02-15 22:21 ` Dave Chinner
2012-02-17 17:38 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 3/9] xfs: remove the per-filesystem list of dquots Christoph Hellwig
2012-02-15 22:59 ` Dave Chinner
2012-02-17 17:47 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 4/9] xfs: use per-CPU data for the quota statistics Christoph Hellwig
2012-02-15 23:59 ` Dave Chinner
2012-02-17 17:48 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 5/9] xfs: user per-cpu stats for the total dquot numbers Christoph Hellwig
2012-02-16 0:02 ` Dave Chinner [this message]
2012-02-17 17:48 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 6/9] xfs: remove the global xfs_Gqm structure Christoph Hellwig
2012-02-16 0:07 ` Dave Chinner
2012-02-15 2:29 ` [PATCH 7/9] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota Christoph Hellwig
2012-02-16 0:11 ` Dave Chinner
2012-02-27 1:57 ` Ben Myers
2012-02-15 2:29 ` [PATCH 8/9] xfs: include reservations in quota reporting Christoph Hellwig
2012-02-16 0:14 ` Dave Chinner
2012-02-15 2:29 ` [PATCH 9/9] quota: make Q_XQUOTASYNC a noop Christoph Hellwig
2012-02-16 0:15 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216000243.GQ14132@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox