From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [patch 00/12] log grant code cleanups
Date: Thu, 16 Feb 2012 15:46:09 -0600 [thread overview]
Message-ID: <20120216214609.GB7762@sgi.com> (raw)
In-Reply-To: <20111212141346.986825692@bombadil.infradead.org>
Christoph,
On Mon, Dec 12, 2011 at 09:13:47AM -0500, Christoph Hellwig wrote:
> This series removes the opportunistic log space wakeups which had no
> use but hiding real races for far too long, and applies various bits
> of refactoring to the log grant code to make it smaller and more readable.
This patch set looks just about ready to go. The only changes I'd like
to see are some commit messages where they are missing, and I have a
question about patch 11 related to usage t_ocnt on the log ticket.
Really nice cleanups.
-Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-16 21:46 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 14:13 [patch 00/12] log grant code cleanups Christoph Hellwig
2011-12-12 14:13 ` [patch 01/12] xfs: split tail_lsn assignments from log space wakeups Christoph Hellwig
2012-01-17 18:48 ` Mark Tinguely
2012-01-25 16:09 ` Christoph Hellwig
2012-02-16 18:21 ` Ben Myers
2012-02-17 19:21 ` Christoph Hellwig
2011-12-12 14:13 ` [patch 02/12] xfs: do exact log space wakeups in xlog_ungrant_log_space Christoph Hellwig
2012-01-17 22:42 ` Mark Tinguely
2012-02-16 18:36 ` Ben Myers
2011-12-12 14:13 ` [patch 03/12] xfs: remove xfs_trans_unlocked_item Christoph Hellwig
2012-01-23 14:31 ` Mark Tinguely
2012-02-16 18:51 ` Ben Myers
2011-12-12 14:13 ` [patch 04/12] xfs: cleanup xfs_log_space_wake Christoph Hellwig
2012-01-23 19:22 ` Mark Tinguely
2012-01-25 16:10 ` Christoph Hellwig
2012-01-25 19:09 ` Mark Tinguely
2012-01-26 16:13 ` Mark Tinguely
2012-01-26 22:12 ` Dave Chinner
2012-02-16 19:06 ` Ben Myers
2011-12-12 14:13 ` [patch 05/12] xfs: remove log space waitqueues Christoph Hellwig
2012-01-23 21:58 ` Mark Tinguely
2011-12-12 14:13 ` [patch 06/12] xfs: add the xlog_grant_head structure Christoph Hellwig
2012-01-24 15:35 ` Mark Tinguely
2012-02-16 20:23 ` Ben Myers
2011-12-12 14:13 ` [patch 07/12] xfs: add xlog_grant_head_init Christoph Hellwig
2012-01-24 15:43 ` Mark Tinguely
2012-02-16 20:29 ` Ben Myers
2011-12-12 14:13 ` [patch 08/12] xfs: add xlog_grant_head_wake_all Christoph Hellwig
2012-01-24 15:46 ` Mark Tinguely
2012-02-16 20:44 ` Ben Myers
2011-12-12 14:13 ` [patch 09/12] xfs: share code for grant head waiting Christoph Hellwig
2012-01-24 18:10 ` Mark Tinguely
2012-02-16 20:51 ` Ben Myers
2011-12-12 14:13 ` [patch 10/12] xfs: shared code for grant head wakeups Christoph Hellwig
2012-01-24 18:37 ` Mark Tinguely
2012-02-16 21:08 ` Ben Myers
2011-12-12 14:13 ` [patch 11/12] xfs: share code for grant head availability checks Christoph Hellwig
2012-01-24 18:53 ` Mark Tinguely
2012-02-16 21:25 ` Ben Myers
2012-02-17 2:41 ` Dave Chinner
2011-12-12 14:13 ` [patch 12/12] xfs: split and cleanup xfs_log_reserve Christoph Hellwig
2012-02-16 21:36 ` Ben Myers
2012-02-19 21:16 ` Christoph Hellwig
2012-02-16 6:16 ` [patch 00/12] log grant code cleanups Dave Chinner
2012-02-17 18:00 ` Christoph Hellwig
2012-02-16 21:46 ` Ben Myers [this message]
2012-02-19 21:17 ` Christoph Hellwig
2012-02-20 21:59 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216214609.GB7762@sgi.com \
--to=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox