From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: more careful size grep in 256
Date: Fri, 17 Feb 2012 12:21:10 -0500 [thread overview]
Message-ID: <20120217172110.GA21610@infradead.org> (raw)
In-Reply-To: <4F3AA739.1000009@redhat.com>
On Tue, Feb 14, 2012 at 10:26:01AM -0800, Eric Sandeen wrote:
> Removing the "-F" flag in xfs_io changed stat output.
>
> Before the change when -F was used, whether or not the file
> was on xfs, it skipped the extra FSGEOM call. Now that -F is
> removed, it calls FSGEOM if the file is on an xfs fs. The "size"
> grep in test 256 was a bit too loose and matched 2 lines if the
> FSGEOM output was present, breaking the test.
>
> A more specific grep for stat.size fixes this.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-02-17 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 18:26 [PATCH] xfstests: more careful size grep in 256 Eric Sandeen
2012-02-17 17:21 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217172110.GA21610@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox