From: Christoph Hellwig <hch@infradead.org>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_fsr: Get the last mount on a specific mount point
Date: Fri, 17 Feb 2012 12:26:39 -0500 [thread overview]
Message-ID: <20120217172639.GA21796@infradead.org> (raw)
In-Reply-To: <20120215123143.GA22051@andromeda.usersys.redhat.com>
On Wed, Feb 15, 2012 at 10:31:43AM -0200, Carlos Maiolino wrote:
> I would change a little this sentence, looks a little confusing at least for me.
> How about:
>
> /* If we found an entry based on the device name, make sure we
> * stat the mount point given by mtab and ensure it's accessible
> * before using it.
> */
Agreed, I'll redo it.
> > + if (S_ISLNK(sb.st_mode)) {
> > + struct stat64 sb2;
>
> Particularly, I don't like variable declarations between statements, but I'm not
> too experienced to say what's good or not :)
The idea is to keep variable declarations as local as possible.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-17 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 18:41 [PATCH] xfs_fsr: Get the last mount on a specific mount point Carlos Maiolino
2012-02-13 17:42 ` Christoph Hellwig
2012-02-15 12:31 ` Carlos Maiolino
2012-02-17 17:26 ` Christoph Hellwig [this message]
2012-02-17 23:36 ` Eric Sandeen
2012-04-24 20:14 ` Carlos Maiolino
2012-04-24 20:57 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217172639.GA21796@infradead.org \
--to=hch@infradead.org \
--cc=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox