From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/8] xfs: use common code for quota statistics
Date: Tue, 21 Feb 2012 08:33:22 +1100 [thread overview]
Message-ID: <20120220213322.GC3592@dastard> (raw)
In-Reply-To: <20120220022904.060961294@bombadil.infradead.org>
On Sun, Feb 19, 2012 at 09:28:19PM -0500, Christoph Hellwig wrote:
> Switch the quota code over to use the generic XFS statistics infrastructure.
> While the legacy /proc/fs/xfs/xqm and /proc/fs/xfs/xqmstats interfaces are
> preserved for now the statistics that still have a meaning with the current
> code are now also available from /proc/fs/xfs/stats.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks OK. Just one question/observation, though. This will make the
quota proc files show up even even quota is not compiled in. Are
there any applications out there that make use of the presence of
these files to determine if quota is configured into the kernel or
not?
I think I just answered my own question - xfstests does exactly this
proc file test in _require_quota(). So I think their presence needs
to be conditional on CONFIG_XFS_QUOTA....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-20 21:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 2:28 [PATCH 0/8] quota updates, V3 Christoph Hellwig
2012-02-20 2:28 ` [PATCH 1/8] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota Christoph Hellwig
2012-02-27 1:59 ` Ben Myers
2012-02-27 17:17 ` Christoph Hellwig
2012-02-27 17:23 ` Ben Myers
2012-02-28 3:27 ` Christoph Hellwig
2012-02-29 17:40 ` Ben Myers
2012-02-20 2:28 ` [PATCH 2/8] xfs: include reservations in quota reporting Christoph Hellwig
2012-02-29 19:37 ` Ben Myers
2012-02-20 2:28 ` [PATCH 3/8] quota: make Q_XQUOTASYNC a noop Christoph Hellwig
2012-02-29 20:00 ` Ben Myers
2012-02-20 2:28 ` [PATCH 4/8] xfs: use common code for quota statistics Christoph Hellwig
2012-02-20 21:33 ` Dave Chinner [this message]
2012-02-20 21:50 ` Christoph Hellwig
2012-02-21 1:48 ` [PATCH 4/8 v2] " Christoph Hellwig
2012-02-21 4:41 ` Dave Chinner
2012-03-12 17:55 ` Ben Myers
2012-03-13 8:42 ` Christoph Hellwig
2012-03-13 15:27 ` Ben Myers
2012-03-13 21:40 ` Dave Chinner
2012-03-14 2:34 ` Nathan Scott
2012-03-14 5:03 ` Dave Chinner
2012-02-20 2:28 ` [PATCH 5/8] xfs: per-filesystem dquot LRU lists Christoph Hellwig
2012-02-20 22:08 ` Dave Chinner
2012-03-12 20:37 ` Ben Myers
2012-02-20 2:28 ` [PATCH 6/8] xfs: use per-filesystem radix trees for dquot lookup Christoph Hellwig
2012-02-20 2:28 ` [PATCH 7/8] xfs: remove the per-filesystem list of dquots Christoph Hellwig
2012-02-20 22:15 ` Dave Chinner
2012-02-20 22:19 ` Christoph Hellwig
2012-02-28 3:31 ` [PATCH 7/8 v2] " Christoph Hellwig
2012-02-20 2:28 ` [PATCH 8/8] xfs: remove the global xfs_Gqm structure Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220213322.GC3592@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox