From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q1KLxc6G112571 for ; Mon, 20 Feb 2012 15:59:38 -0600 Date: Mon, 20 Feb 2012 15:59:42 -0600 From: Ben Myers Subject: Re: [patch 00/12] log grant code cleanups Message-ID: <20120220215942.GK28391@sgi.com> References: <20111212141346.986825692@bombadil.infradead.org> <20120216214609.GB7762@sgi.com> <20120219211706.GB22831@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120219211706.GB22831@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Sun, Feb 19, 2012 at 04:17:06PM -0500, Christoph Hellwig wrote: > On Thu, Feb 16, 2012 at 03:46:09PM -0600, Ben Myers wrote: > > On Mon, Dec 12, 2011 at 09:13:47AM -0500, Christoph Hellwig wrote: > > > This series removes the opportunistic log space wakeups which had no > > > use but hiding real races for far too long, and applies various bits > > > of refactoring to the log grant code to make it smaller and more readable. > > > > This patch set looks just about ready to go. The only changes I'd like > > to see are some commit messages where they are missing, and I have a > > question about patch 11 related to usage t_ocnt on the log ticket. > > For the "share ..." commits I can't really think of any commit message > that actually makes sense - the subject seems to describe what the patch > does more than enough. It would help the reviewer if you were less terse in your commit messages. Not everyone is as sharp as you are. ;) -Ben _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs