From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 6/8] xfs: make xfs_inode_item_size idempotent
Date: Tue, 21 Feb 2012 16:14:04 +1100 [thread overview]
Message-ID: <20120221051404.GM3592@dastard> (raw)
In-Reply-To: <20120221003907.081625923@bombadil.infradead.org>
On Mon, Feb 20, 2012 at 07:38:30PM -0500, Christoph Hellwig wrote:
> Move all code messing with the inode log item flags into xfs_inode_item_format
> to make sure xfs_inode_item_size really only calculates the the number of
> vectors, but doesn't modify any state of the inode item.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks ok so:
Reviewed-by: Dave Chinner <dchinner@redhat.com>
One minor cleanup:
> case XFS_DINODE_FMT_LOCAL:
> - ASSERT(!(iip->ili_format.ilf_fields &
> - (XFS_ILOG_ABROOT | XFS_ILOG_AEXT)));
> - if (iip->ili_format.ilf_fields & XFS_ILOG_ADATA) {
> + iip->ili_format.ilf_fields &=
> + ~(XFS_ILOG_AEXT | XFS_ILOG_ABROOT);
> +
> + if ((iip->ili_format.ilf_fields & XFS_ILOG_ADATA) &&
> + ip->i_afp->if_bytes > 0) {
> ASSERT(ip->i_afp->if_bytes > 0);
That assert can go - it's checked in the if statement now.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-21 5:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 0:38 [PATCH 0/8] log all inode updates V2 Christoph Hellwig
2012-02-21 0:38 ` [PATCH 1/8] xfs: use per-filesystem I/O completion workqueues Christoph Hellwig
2012-02-21 4:58 ` Dave Chinner
2012-02-28 16:13 ` Mark Tinguely
2012-02-21 0:38 ` [PATCH 2/8] xfs: do not require an ioend for new EOF calculation Christoph Hellwig
2012-02-28 16:14 ` Mark Tinguely
2012-02-21 0:38 ` [PATCH 6/8] xfs: make xfs_inode_item_size idempotent Christoph Hellwig
2012-02-21 5:14 ` Dave Chinner [this message]
2012-02-28 11:08 ` Christoph Hellwig
2012-02-21 0:38 ` [PATCH 7/8] xfs: split in-core and on-disk inode log item fields Christoph Hellwig
2012-02-21 5:18 ` Dave Chinner
2012-02-21 0:38 ` [PATCH 8/8] xfs: add back fdatasync support Christoph Hellwig
2012-02-21 5:23 ` Dave Chinner
2012-03-08 20:04 ` Ben Myers
-- strict thread matches above, loose matches on Subject: below --
2012-02-29 9:53 [PATCH 0/8] log all inode updates V3 Christoph Hellwig
2012-02-29 9:53 ` [PATCH 6/8] xfs: make xfs_inode_item_size idempotent Christoph Hellwig
2012-03-02 16:31 ` Mark Tinguely
2012-03-07 21:02 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221051404.GM3592@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox