From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 8/8] xfs: add back fdatasync support
Date: Tue, 21 Feb 2012 16:23:01 +1100 [thread overview]
Message-ID: <20120221052301.GO3592@dastard> (raw)
In-Reply-To: <20120221003907.518904261@bombadil.infradead.org>
On Mon, Feb 20, 2012 at 07:38:32PM -0500, Christoph Hellwig wrote:
> Add an in-memory only flag to say we logged timestamps only, and use it to
> check if fdatasync can optimize away the log force.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good. Couple of minor things below.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
> +/*
> + * The timestamps in the core are dirty, but not nessecarily anything
necessarily
> + * else.
> + *
> + * This is an incore only value store in ilf_fields & co, which must
> + * never make it to disk, unlike the other fields above.
That comment is a bit incoherent. Perhaps:
* this is an incore-only flag stored in ili_fields which, unlike
* the above flags, must never make it to disk in the ilf_fields.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-21 5:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 0:38 [PATCH 0/8] log all inode updates V2 Christoph Hellwig
2012-02-21 0:38 ` [PATCH 1/8] xfs: use per-filesystem I/O completion workqueues Christoph Hellwig
2012-02-21 4:58 ` Dave Chinner
2012-02-28 16:13 ` Mark Tinguely
2012-02-21 0:38 ` [PATCH 2/8] xfs: do not require an ioend for new EOF calculation Christoph Hellwig
2012-02-28 16:14 ` Mark Tinguely
2012-02-21 0:38 ` [PATCH 6/8] xfs: make xfs_inode_item_size idempotent Christoph Hellwig
2012-02-21 5:14 ` Dave Chinner
2012-02-28 11:08 ` Christoph Hellwig
2012-02-21 0:38 ` [PATCH 7/8] xfs: split in-core and on-disk inode log item fields Christoph Hellwig
2012-02-21 5:18 ` Dave Chinner
2012-02-21 0:38 ` [PATCH 8/8] xfs: add back fdatasync support Christoph Hellwig
2012-02-21 5:23 ` Dave Chinner [this message]
2012-03-08 20:04 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221052301.GO3592@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox