From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 7/9] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota
Date: Sun, 26 Feb 2012 19:57:11 -0600 [thread overview]
Message-ID: <20120227015711.GH7762@sgi.com> (raw)
In-Reply-To: <20120215023148.024760659@bombadil.infradead.org>
Hi Christoph,
On Tue, Feb 14, 2012 at 09:29:33PM -0500, Christoph Hellwig wrote:
> The is no good reason to have these two separate, and for the next change
> I'd need the full struct xfs_dquot in xfs_qm_export_dquot, so better just
> fold the code now instead of changing it around.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
...
> -int
> -xfs_qm_scall_getquota(
...
> - /*
> - * Convert the disk dquot to the exportable format
> - */
> - xfs_qm_export_dquot(mp, &dqp->q_core, out);
> - xfs_qm_dqput(dqp);
> - return (error ? XFS_ERROR(EFAULT) : 0);
> -}
Note that we used to map all errors to EFAULT.
...
> +int
> +xfs_qm_scall_getquota(
...
> +out_put:
> + xfs_qm_dqput(dqp);
> + return error;
And, now we don't.
The rest of the patch looks great to me. If you intend to change the
error code, please mention so in the commit message. Was it wrong
before, or will it be wrong if we pull this in?
Regards,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-27 1:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 2:29 [PATCH 0/9] quota updates V2 Christoph Hellwig
2012-02-15 2:29 ` [PATCH 1/9] xfs: use per-filesystem dquot LRU lists Christoph Hellwig
2012-02-15 22:10 ` Dave Chinner
2012-02-17 17:33 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 2/9] xfs: use per-filesystem radix trees for dquot lookup Christoph Hellwig
2012-02-15 22:21 ` Dave Chinner
2012-02-17 17:38 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 3/9] xfs: remove the per-filesystem list of dquots Christoph Hellwig
2012-02-15 22:59 ` Dave Chinner
2012-02-17 17:47 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 4/9] xfs: use per-CPU data for the quota statistics Christoph Hellwig
2012-02-15 23:59 ` Dave Chinner
2012-02-17 17:48 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 5/9] xfs: user per-cpu stats for the total dquot numbers Christoph Hellwig
2012-02-16 0:02 ` Dave Chinner
2012-02-17 17:48 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 6/9] xfs: remove the global xfs_Gqm structure Christoph Hellwig
2012-02-16 0:07 ` Dave Chinner
2012-02-15 2:29 ` [PATCH 7/9] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota Christoph Hellwig
2012-02-16 0:11 ` Dave Chinner
2012-02-27 1:57 ` Ben Myers [this message]
2012-02-15 2:29 ` [PATCH 8/9] xfs: include reservations in quota reporting Christoph Hellwig
2012-02-16 0:14 ` Dave Chinner
2012-02-15 2:29 ` [PATCH 9/9] quota: make Q_XQUOTASYNC a noop Christoph Hellwig
2012-02-16 0:15 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227015711.GH7762@sgi.com \
--to=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox