From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/8] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota
Date: Wed, 29 Feb 2012 11:40:19 -0600 [thread overview]
Message-ID: <20120229174019.GJ7762@sgi.com> (raw)
In-Reply-To: <20120228032740.GA18306@infradead.org>
On Mon, Feb 27, 2012 at 10:27:40PM -0500, Christoph Hellwig wrote:
> On Mon, Feb 27, 2012 at 11:23:10AM -0600, Ben Myers wrote:
> > On Mon, Feb 27, 2012 at 12:17:27PM -0500, Christoph Hellwig wrote:
> > > > I should have replied to this patch, not the older rev.
> > > >
> > > > I have a question about the error code, now we're not mapping errors to
> > > > EFAULT and we used do... which is correct?
> > >
> > > The old one looks finshy, but we even if we changed it it should be
> > > in a separate patch with a good description. I'll resend with this bit
> > > fixed.
> >
> > Sounds great. ;)
>
> Actually the patch is fine as-is. If you look at the old
> xfs_qm_scall_getquota we'd return any error we get from xfs_qm_dqget
> as-is, and return ENOENT if XFS_IS_DQUOT_UNINITIALIZED is true. The
> place where any other error is converted to EFAULT is never actually
> reached.
Apologies.. I see it now.
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-29 17:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 2:28 [PATCH 0/8] quota updates, V3 Christoph Hellwig
2012-02-20 2:28 ` [PATCH 1/8] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota Christoph Hellwig
2012-02-27 1:59 ` Ben Myers
2012-02-27 17:17 ` Christoph Hellwig
2012-02-27 17:23 ` Ben Myers
2012-02-28 3:27 ` Christoph Hellwig
2012-02-29 17:40 ` Ben Myers [this message]
2012-02-20 2:28 ` [PATCH 2/8] xfs: include reservations in quota reporting Christoph Hellwig
2012-02-29 19:37 ` Ben Myers
2012-02-20 2:28 ` [PATCH 3/8] quota: make Q_XQUOTASYNC a noop Christoph Hellwig
2012-02-29 20:00 ` Ben Myers
2012-02-20 2:28 ` [PATCH 4/8] xfs: use common code for quota statistics Christoph Hellwig
2012-02-20 21:33 ` Dave Chinner
2012-02-20 21:50 ` Christoph Hellwig
2012-02-21 1:48 ` [PATCH 4/8 v2] " Christoph Hellwig
2012-02-21 4:41 ` Dave Chinner
2012-03-12 17:55 ` Ben Myers
2012-03-13 8:42 ` Christoph Hellwig
2012-03-13 15:27 ` Ben Myers
2012-03-13 21:40 ` Dave Chinner
2012-03-14 2:34 ` Nathan Scott
2012-03-14 5:03 ` Dave Chinner
2012-02-20 2:28 ` [PATCH 5/8] xfs: per-filesystem dquot LRU lists Christoph Hellwig
2012-02-20 22:08 ` Dave Chinner
2012-03-12 20:37 ` Ben Myers
2012-02-20 2:28 ` [PATCH 6/8] xfs: use per-filesystem radix trees for dquot lookup Christoph Hellwig
2012-02-20 2:28 ` [PATCH 7/8] xfs: remove the per-filesystem list of dquots Christoph Hellwig
2012-02-20 22:15 ` Dave Chinner
2012-02-20 22:19 ` Christoph Hellwig
2012-02-28 3:31 ` [PATCH 7/8 v2] " Christoph Hellwig
2012-02-20 2:28 ` [PATCH 8/8] xfs: remove the global xfs_Gqm structure Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229174019.GJ7762@sgi.com \
--to=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox