Re: [PATCH 4/8] xfs: use common code for quota statistics

Dave Chinner
2012-02-20T21:33:28Z

On Sun, Feb 19, 2012 at 09:28:19PM -0500, Christoph Hellwig wrote:
> Switch the quota code over to use the generic XFS statistics infrastructure.
> While the legacy /proc/fs/xfs/xqm and /proc/fs/xfs/xqmstats interfaces are
> preserved for now the statistics that still have a meaning with the current
> code are now also available from /proc/fs/xfs/stats.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks OK. Just one question/observation, though. This will make the
quota proc files show up even even quota is not compiled in. Are
there any applications out there that make use of the presence of
these files to determine if quota is configured into the kernel or
not?

I think I just answered my own question - xfstests does exactly this
proc file test in _require_quota(). So I think their presence needs
to be conditional on CONFIG_XFS_QUOTA....

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com