Re: [PATCH 1/8] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota

Ben Myers
2012-02-27T01:59:37Z

Hi Christoph,

On Sun, Feb 19, 2012 at 09:28:16PM -0500, Christoph Hellwig wrote:
> The is no good reason to have these two separate, and for the next change
> we would need the full struct xfs_dquot in xfs_qm_export_dquot, so better
> just fold the code now instead of changing it spuriously.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

I should have replied to this patch, not the older rev.

I have a question about the error code, now we're not mapping errors to
EFAULT and we used do... which is correct?

Thanks,
Ben