Re: [PATCH 4/8 v2] xfs: use common code for quota statistics

Christoph Hellwig
2012-03-13T08:42:44Z

On Mon, Mar 12, 2012 at 12:55:19PM -0500, Ben Myers wrote:
> > +static int xqm_proc_show(struct seq_file *m, void *v)
> > +{
> > + /* maximum; incore; ratio free to inuse; freelist */
> > + seq_printf(m, "%d\t%d\t%d\t%u\n",
> > + 0,
> > + counter_val(XFSSTAT_END_XQMSTAT),
>
> That's xfs_qm_dquot
>
> > + 0,
> > + counter_val(XFSSTAT_END_XQMSTAT + 1));
>
> and xfs_qm_dquot_unused? A comment would make your intent clear.

In that case we'd have to comment the existing code, too. And in that
case reoding the code to actually make sense would be a good idea as
well.

> This patch looks great. It might break some PCP scripts, I'm not sure.

Why would it break them? The existing stats are still kept around, and
new additions to the main stats file are expected to happen once in a
while.