Re: [PATCH 1/8] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota

Ben Myers
2012-02-29T17:40:16Z

On Mon, Feb 27, 2012 at 10:27:40PM -0500, Christoph Hellwig wrote:
> On Mon, Feb 27, 2012 at 11:23:10AM -0600, Ben Myers wrote:
> > On Mon, Feb 27, 2012 at 12:17:27PM -0500, Christoph Hellwig wrote:
> > > > I should have replied to this patch, not the older rev.
> > > >
> > > > I have a question about the error code, now we're not mapping errors to
> > > > EFAULT and we used do... which is correct?
> > >
> > > The old one looks finshy, but we even if we changed it it should be
> > > in a separate patch with a good description. I'll resend with this bit
> > > fixed.
> >
> > Sounds great. ;)
>
> Actually the patch is fine as-is. If you look at the old
> xfs_qm_scall_getquota we'd return any error we get from xfs_qm_dqget
> as-is, and return ENOENT if XFS_IS_DQUOT_UNINITIALIZED is true. The
> place where any other error is converted to EFAULT is never actually
> reached.

Apologies.. I see it now.

Reviewed-by: Ben Myers <bpm@sgi.com>