public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Goswin von Brederlow <goswin-v-b@web.de>
To: Debian Bug Tracking System <661580@bugs.debian.org>
Subject: Bug#661580: mkfs.xfs fails to detect correct sector size
Date: Thu, 01 Mar 2012 09:14:09 +0100	[thread overview]
Message-ID: <20120301081409.3103.43155.reportbug@frosties.localnet> (raw)

Package: xfsprogs
Version: 3.1.7
Followup-For: Bug #661580

Hi again,

I've patched the NBD driver to set the physical sector size. Was way
easier than I imagined:

----------------------------------------------------------------------
--- linux/drivers/block/nbd.c~      2012-03-01 09:10:35.000000000 +0100
+++ linux/drivers/block/nbd.c       2012-03-01 08:57:49.000000000 +0100
@@ -413,6 +413,9 @@
                return ret;
        }
 
+       /* Set physical block size to blocksize */
+       blk_queue_physical_block_size(lo->disk->queue, lo->blksize);
+
        while ((req = nbd_read_stat(lo)) != NULL)
                nbd_end_request(req);
 
----------------------------------------------------------------------

And I can confirm that the sector size detection is still broken in
3.1.7.

root@frosties:~$ parted /dev/nbd0
GNU Parted 2.3
Using /dev/nbd0
Welcome to GNU Parted! Type 'help' to view a list of commands.
(parted) p                                                                
Model: Unknown (unknown)
Disk /dev/nbd0: 16.8MB
Sector size (logical/physical): 512B/4096B
Partition Table: loop

Number  Start  End     Size    File system  Flags
 1      0.00B  16.8MB  16.8MB  xfs

(parted) q                                                                
root@frosties:~$ mkfs.xfs -f /dev/nbd0 
meta-data=/dev/nbd0              isize=256    agcount=1, agsize=4096 blks
         =                       sectsz=512   attr=2, projid32bit=0
data     =                       bsize=4096   blocks=4096, imaxpct=25
         =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0
log      =internal log           bsize=4096   blocks=1200, version=2
         =                       sectsz=512   sunit=0 blks, lazy-count=1
realtime =none                   extsz=4096   blocks=0, rtextents=0

mrvn@frosties:~% tail /sys/block/nbd0/queue/*
==> /sys/block/nbd0/queue/add_random <==
1

==> /sys/block/nbd0/queue/discard_granularity <==
0

==> /sys/block/nbd0/queue/discard_max_bytes <==
0

==> /sys/block/nbd0/queue/discard_zeroes_data <==
0

==> /sys/block/nbd0/queue/hw_sector_size <==
512

==> /sys/block/nbd0/queue/iosched <==
tail: error reading `/sys/block/nbd0/queue/iosched': Is a directory

==> /sys/block/nbd0/queue/iostats <==
1

==> /sys/block/nbd0/queue/logical_block_size <==
512

==> /sys/block/nbd0/queue/max_hw_sectors_kb <==
127

==> /sys/block/nbd0/queue/max_integrity_segments <==
0

==> /sys/block/nbd0/queue/max_sectors_kb <==
127

==> /sys/block/nbd0/queue/max_segment_size <==
65536

==> /sys/block/nbd0/queue/max_segments <==
128

==> /sys/block/nbd0/queue/minimum_io_size <==
4096

==> /sys/block/nbd0/queue/nomerges <==
0

==> /sys/block/nbd0/queue/nr_requests <==
128

==> /sys/block/nbd0/queue/optimal_io_size <==
0

==> /sys/block/nbd0/queue/physical_block_size <==
4096

==> /sys/block/nbd0/queue/read_ahead_kb <==
128

==> /sys/block/nbd0/queue/rotational <==
0

==> /sys/block/nbd0/queue/rq_affinity <==
1

==> /sys/block/nbd0/queue/scheduler <==
noop deadline [cfq] 


MfG
	Goswin

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.1.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=de_DE (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash

Versions of packages xfsprogs depends on:
ii  libblkid1     2.20.1-1
ii  libc6         2.13-21 
ii  libreadline5  5.2-11  
ii  libuuid1      2.19.1-5

xfsprogs recommends no packages.

Versions of packages xfsprogs suggests:
pn  acl      2.2.51-4  
pn  attr     1:2.4.46-3
pn  quota    <none>    
pn  xfsdump  <none>    

-- no debconf information


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2012-03-01  8:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-01  8:14 Goswin von Brederlow [this message]
2012-03-01  8:33 ` Bug#661580: mkfs.xfs fails to detect correct sector size Christoph Hellwig
2012-03-01  9:07   ` Goswin von Brederlow
2012-03-01 20:55   ` Eric Sandeen
2012-03-02  5:05     ` Eric Sandeen
  -- strict thread matches above, loose matches on Subject: below --
2012-02-28  7:49 Goswin von Brederlow
2012-02-28  9:11 ` Christoph Hellwig
2012-02-28 13:28   ` Carlos Maiolino
2012-02-28 19:19   ` Goswin von Brederlow
2012-02-29 19:56   ` Eric Sandeen
2012-03-01  3:53     ` Goswin von Brederlow
2012-03-01  6:06       ` Christoph Hellwig
2012-03-01  8:56         ` Goswin von Brederlow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120301081409.3103.43155.reportbug@frosties.localnet \
    --to=goswin-v-b@web.de \
    --cc=661580@bugs.debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox