From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: pick up 4k physical sector size
Date: Fri, 2 Mar 2012 11:20:43 +1100 [thread overview]
Message-ID: <20120302002043.GD5091@dastard> (raw)
In-Reply-To: <4F500690.2080804@redhat.com>
On Thu, Mar 01, 2012 at 05:30:24PM -0600, Eric Sandeen wrote:
> This splits the fs topology sectorsize into logical & physical,
> and gets both via blkid_get_topology.
>
> After that there are various gyrations & warnings to handle
> various combinations of specified sector, blocksize, and
> what's actually found on disk.
>
> mkfs.xfs's "sector size" gets reduced to logical if
> a block size < physical sector size is specified, for
> example.
Looks good, just a minor comment:
> + sectorsize = ft.psectorsize ? ft.psectorsize :
> + XFS_MIN_SECTORSIZE;
> +
> + if ((blocksize < sectorsize) && (blocksize >= ft.lsectorsize)) {
> + fprintf(stderr, _("specified blocksize %d is less than "
> + "device physical sector size %d\n"),
> + blocksize, ft.psectorsize);
i wouldn't break the format string like that. Doing:
fprintf(stderr,
_("specified blocksize %d is less than device physical sector size %d\n"),
blocksize, ft.psectorsize);
Is consistent with long format strings elsewhere in the xfsprogs
code, and it makes grepping easy. Same for each of the other long
format strings you broke in half...
Other than that, consider it:
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-02 0:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 23:30 [PATCH] xfsprogs: pick up 4k physical sector size Eric Sandeen
2012-03-02 0:20 ` Dave Chinner [this message]
2012-03-09 21:52 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302002043.GD5091@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox