From: Christoph Hellwig <hch@infradead.org>
To: Kamal Dasu <kdasu.kdev@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfsprogs: replace deprecated ustat call with statfs in libxfs/linux.c
Date: Fri, 2 Mar 2012 02:45:58 -0500 [thread overview]
Message-ID: <20120302074558.GB4117@infradead.org> (raw)
In-Reply-To: <de74feb44ebd887269fe85d9a5879765afccf4c2.1330635228.git.kdasu.kdev@gmail.com>
On Thu, Mar 01, 2012 at 04:11:24PM -0500, Kamal Dasu wrote:
> >From the ustat man page
>
> NOTES
> ustat() is deprecated and has only been provided for compatibility.
> All new programs should use statfs(2) instead.
xfsprogs isn't new :)
More seriously - ustat provides the benefit to check if the block device
is mounted anywhere, which we make use of here. A statfs of the block
device path doesn't provide that functionality at all.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-02 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 21:11 [PATCH 0/2] xfsprogs: Replace deprecated ustat and sig(relse/hold) glibc APIs Kamal Dasu
2012-03-01 21:11 ` [PATCH 1/2] xfsprogs: replace deprecated ustat call with statfs in libxfs/linux.c Kamal Dasu
2012-03-01 21:11 ` [PATCH 2/2] xfsprogs: Use Posix signal API signprocmask instead of sigrelse/sighold in xfs_copy.c Kamal Dasu
2012-03-02 7:45 ` Christoph Hellwig [this message]
2012-03-05 16:16 ` [PATCH 1/2] xfsprogs: replace deprecated ustat call with statfs in libxfs/linux.c Kamal Dasu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302074558.GB4117@infradead.org \
--to=hch@infradead.org \
--cc=kdasu.kdev@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox