From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V3] xfstests 279: test mkfs with various sector sizes & alignments
Date: Fri, 9 Mar 2012 10:11:58 +1100 [thread overview]
Message-ID: <20120308231158.GT3592@dastard> (raw)
In-Reply-To: <4F5931BF.8010503@sandeen.net>
On Thu, Mar 08, 2012 at 04:25:03PM -0600, Eric Sandeen wrote:
> On 3/2/12 10:58 AM, Eric Sandeen wrote:
> > This test uses the scsi_debug module to test mkfs against
> > various physical & logical sector sizes, and with aligned
> > and unaligned devices.
> >
> > Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> > ---
> >
> > Dave, I think this implements all your suggestions (in one way or
> > another...) except the non-modular scsi_debug. I don't know
> > how to manipulate things like offset if it's built in, but
> > if you want to look... I don't see it.
> >
> > V3: remove a couple stray/extra "tee" commands
> >
> > I looked into doing a generic version of this but I think without
> > the sector size checking unique to xfs it's a little pointless.
>
> Dave, think this is ok now?
Yup.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-03-08 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 23:27 [PATCH] xfstests 279: test mkfs with various sector sizes & alignments Eric Sandeen
2012-03-02 0:15 ` Dave Chinner
2012-03-02 3:46 ` Eric Sandeen
2012-03-02 4:28 ` Dave Chinner
2012-03-02 4:07 ` [PATCH V2] " Eric Sandeen
2012-03-02 16:58 ` [PATCH V3] " Eric Sandeen
2012-03-08 22:25 ` Eric Sandeen
2012-03-08 23:11 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308231158.GT3592@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox