From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q2CDS5PY082714 for ; Mon, 12 Mar 2012 08:28:05 -0500 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id HxpXBIGYnwRiAe4p (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 12 Mar 2012 06:28:04 -0700 (PDT) Date: Mon, 12 Mar 2012 09:28:03 -0400 From: Christoph Hellwig Subject: Re: [PATCH 04/10] xfs: fallback to vmalloc for large buffers in xfs_getbmap Message-ID: <20120312132803.GD25944@infradead.org> References: <1331095828-28742-1-git-send-email-david@fromorbit.com> <1331095828-28742-5-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1331095828-28742-5-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Wed, Mar 07, 2012 at 03:50:22PM +1100, Dave Chinner wrote: > From: Dave Chinner > > xfs_getbmap uses for a large buffer for extents, which is kmalloc'd. > This can fail after the system has been running for some time as it > is a high order allocation. Add a fallback to vmalloc so that it > doesn't require contiguous memory and so won't randomly fail on > files with large extent lists. Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs