From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: 3.2.9 and locking problem
Date: Tue, 13 Mar 2012 11:00:52 +1100 [thread overview]
Message-ID: <20120313000052.GB5091@dastard> (raw)
In-Reply-To: <20120312161425.GA23815@infradead.org>
On Mon, Mar 12, 2012 at 12:14:25PM -0400, Christoph Hellwig wrote:
> In the 3.2 version xfs_sync_flags does a double unlock of the ilock -
> change the last argument of xfs_trans_ijoin from XFS_ILOCK_EXCL to 0
> will fix this. The 3.0 version doesn't have this bug.
>
> And btw, the additions to the on-disk format are gross - this stuff
> broke before and will break again when we add new features.
Any idea why they aren't sending stuff like this upstream to us so
they can be implemented correctly, robustly and in a future-proof
manner? vserver users are going to be unhappy when their filesystems
get broken because they are using out-of-tree, incompatible on-disk
formats....
FWIW, are the vserver foilks distributing modified versions of
xfsprogs to support these changes?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-03-13 0:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 19:28 3.2.9 and locking problem Arkadiusz Miśkiewicz
2012-03-12 0:53 ` Dave Chinner
2012-03-12 13:43 ` Arkadiusz Miśkiewicz
2012-03-12 16:14 ` Christoph Hellwig
2012-03-12 17:49 ` Richard Ems
2012-03-12 18:02 ` Christoph Hellwig
2012-03-13 0:00 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313000052.GB5091@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox