From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/5] xfs: use per-filesystem radix trees for dquot lookup
Date: Tue, 13 Mar 2012 12:06:02 -0500 [thread overview]
Message-ID: <20120313170602.GH7762@sgi.com> (raw)
In-Reply-To: <20120313085308.824843587@bombadil.infradead.org>
On Tue, Mar 13, 2012 at 04:52:35AM -0400, Christoph Hellwig wrote:
> Replace the global hash tables for looking up in-memory dquot structures
> with per-filesystem radix trees to allow scaling to a large number of
> in-memory dquot structures.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
...
> @@ -780,51 +712,27 @@ restart:
> }
> }
>
> - /*
> - * Hashlock comes after ilock in lock order
> - */
> - mutex_lock(&h->qh_lock);
> - if (version != h->qh_version) {
> - xfs_dquot_t *tmpdqp;
> + mutex_lock(&qi->qi_tree_lock);
> + error = -radix_tree_insert(tree, id, dqp);
> + if (unlikely(error)) {
> + WARN_ON(error != EEXIST);
Yeah, radix_tree_insert can return ENOMEM.
Looks good.
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-13 17:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 8:52 [PATCH 0/5] quota updates V4 Christoph Hellwig
2012-03-13 8:52 ` [PATCH 1/5] xfs: use common code for quota statistics Christoph Hellwig
2012-03-13 21:47 ` Dave Chinner
2012-03-13 8:52 ` [PATCH 2/5] xfs: per-filesystem dquot LRU lists Christoph Hellwig
2012-03-13 21:50 ` Dave Chinner
2012-03-13 8:52 ` [PATCH 3/5] xfs: use per-filesystem radix trees for dquot lookup Christoph Hellwig
2012-03-13 17:06 ` Ben Myers [this message]
2012-03-13 8:52 ` [PATCH 4/5] xfs: remove the per-filesystem list of dquots Christoph Hellwig
2012-03-13 20:03 ` Ben Myers
2012-03-13 21:54 ` Dave Chinner
2012-03-13 21:58 ` Ben Myers
2012-03-14 7:34 ` Christoph Hellwig
2012-03-14 16:36 ` Ben Myers
2012-03-13 8:52 ` [PATCH 5/5] xfs: remove the global xfs_Gqm structure Christoph Hellwig
2012-03-13 20:53 ` Ben Myers
2012-03-13 20:54 ` [PATCH 0/5] quota updates V4 Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313170602.GH7762@sgi.com \
--to=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox