From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 4/5] xfs: remove the per-filesystem list of dquots
Date: Tue, 13 Mar 2012 16:58:45 -0500 [thread overview]
Message-ID: <20120313215845.GM8545@sgi.com> (raw)
In-Reply-To: <20120313215409.GI5091@dastard>
On Wed, Mar 14, 2012 at 08:54:09AM +1100, Dave Chinner wrote:
> On Tue, Mar 13, 2012 at 03:03:54PM -0500, Ben Myers wrote:
> > On Tue, Mar 13, 2012 at 04:52:36AM -0400, Christoph Hellwig wrote:
> > > + struct xfs_dquot *batch[XFS_DQ_LOOKUP_BATCH];
> >
> > Eesh.. that probably doesn't need to go onto the stack. I know we are
> > doing it elsewhere too, and that we also sometimes complain about other
> > peoples' stack usage. Don't necessarily have to clean it up now,
> > though. ;)
>
> Actually, if we do the walk from the shrinker we can't reliably
> allocate it, so it has to go on the stack.
D'oh, I missed that idea completely in my review. :/
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-13 21:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 8:52 [PATCH 0/5] quota updates V4 Christoph Hellwig
2012-03-13 8:52 ` [PATCH 1/5] xfs: use common code for quota statistics Christoph Hellwig
2012-03-13 21:47 ` Dave Chinner
2012-03-13 8:52 ` [PATCH 2/5] xfs: per-filesystem dquot LRU lists Christoph Hellwig
2012-03-13 21:50 ` Dave Chinner
2012-03-13 8:52 ` [PATCH 3/5] xfs: use per-filesystem radix trees for dquot lookup Christoph Hellwig
2012-03-13 17:06 ` Ben Myers
2012-03-13 8:52 ` [PATCH 4/5] xfs: remove the per-filesystem list of dquots Christoph Hellwig
2012-03-13 20:03 ` Ben Myers
2012-03-13 21:54 ` Dave Chinner
2012-03-13 21:58 ` Ben Myers [this message]
2012-03-14 7:34 ` Christoph Hellwig
2012-03-14 16:36 ` Ben Myers
2012-03-13 8:52 ` [PATCH 5/5] xfs: remove the global xfs_Gqm structure Christoph Hellwig
2012-03-13 20:53 ` Ben Myers
2012-03-13 20:54 ` [PATCH 0/5] quota updates V4 Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313215845.GM8545@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox