From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 10/10] xfs: don't cache inodes read through bulkstat
Date: Thu, 15 Mar 2012 13:14:26 -0500 [thread overview]
Message-ID: <20120315181426.GO7762@sgi.com> (raw)
In-Reply-To: <1331095828-28742-11-git-send-email-david@fromorbit.com>
On Wed, Mar 07, 2012 at 03:50:28PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> When we read inodes via bulkstat, we generally only read them once
> and then throw them away - they never get used again. If we retain
> them in cache, then it simply causes the working set of inodes and
> other cached items to be reclaimed just so the inode cache can grow.
>
> Avoid this problem by marking inodes read by bulkstat as not to be
> cached and check this flag in .drop_inode to determine whether the
> inode should be added to the VFS LRU or not. If the inode lookup
> hits an already cached inode, then don't set the flag. If the inode
> lookup hits an inode marked with no cache flag, remove the flag and
> allow it to be cached once the current reference goes away.
>
> Inodes marked as not cached will get cleaned up by the background
> inode reclaim or via memory pressure, so they will still generate
> some short term cache pressure. They will, however, be reclaimed
> much sooner and in preference to cache hot inodes.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/xfs_iget.c | 8 ++++++--
> fs/xfs/xfs_inode.h | 4 +++-
> fs/xfs/xfs_itable.c | 3 ++-
> fs/xfs/xfs_super.c | 17 +++++++++++++++++
> 4 files changed, 28 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_iget.c b/fs/xfs/xfs_iget.c
> index 93fc1dc..20ddb1e 100644
> --- a/fs/xfs/xfs_iget.c
> +++ b/fs/xfs/xfs_iget.c
> @@ -290,7 +290,7 @@ xfs_iget_cache_hit(
> if (lock_flags != 0)
> xfs_ilock(ip, lock_flags);
>
> - xfs_iflags_clear(ip, XFS_ISTALE);
> + xfs_iflags_clear(ip, XFS_ISTALE | XFS_IDONTCACHE);
If XFS_IGET_DONTCACHE is set, maybe you don't want to clear
XFS_IDONTCACHE.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-15 18:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 4:50 [PATCH 0/10] xfs: various fixes v2 Dave Chinner
2012-03-07 4:50 ` [PATCH 01/10] xfs: clean up minor sparse warnings Dave Chinner
2012-03-08 21:34 ` Ben Myers
2012-03-09 0:30 ` Dave Chinner
2012-03-07 4:50 ` [PATCH 02/10] xfs: Fix open flag handling in open_by_handle code Dave Chinner
2012-03-12 13:27 ` Christoph Hellwig
2012-03-13 21:15 ` Mark Tinguely
2012-03-07 4:50 ` [PATCH 03/10] xfs: fallback to vmalloc for large buffers in xfs_attrmulti_attr_get Dave Chinner
2012-03-12 13:27 ` Christoph Hellwig
2012-03-14 18:04 ` Mark Tinguely
2012-03-07 4:50 ` [PATCH 04/10] xfs: fallback to vmalloc for large buffers in xfs_getbmap Dave Chinner
2012-03-12 13:28 ` Christoph Hellwig
2012-03-14 18:12 ` Mark Tinguely
2012-03-07 4:50 ` [PATCH 05/10] xfs: introduce an allocation workqueue Dave Chinner
2012-03-12 16:16 ` Christoph Hellwig
2012-03-19 16:47 ` Mark Tinguely
2012-03-19 22:20 ` Dave Chinner
2012-03-20 16:34 ` Mark Tinguely
2012-03-20 22:45 ` Dave Chinner
2012-03-07 4:50 ` [PATCH 06/10] xfs: remove remaining scraps of struct xfs_iomap Dave Chinner
2012-03-15 16:48 ` Mark Tinguely
2012-03-07 4:50 ` [PATCH 07/10] xfs: fix inode lookup race Dave Chinner
2012-03-07 4:50 ` [PATCH 08/10] xfs: initialise xfssync work before running quotachecks Dave Chinner
2012-03-12 13:28 ` Christoph Hellwig
2012-03-16 17:07 ` Mark Tinguely
2012-03-07 4:50 ` [PATCH 09/10] xfs: remove MS_ACTIVE guard from inode reclaim work Dave Chinner
2012-03-12 13:30 ` Christoph Hellwig
2012-03-07 4:50 ` [PATCH 10/10] xfs: don't cache inodes read through bulkstat Dave Chinner
2012-03-12 13:31 ` Christoph Hellwig
2012-03-14 20:44 ` Ben Myers
2012-03-15 18:14 ` Ben Myers [this message]
2012-03-15 22:05 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315181426.GO7762@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox