From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ben Myers <bpm@sgi.com>, Alex Elder <elder@kernel.org>,
Jan Kara <jack@suse.cz>,
stable@kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs: Fix oops on IO error during xlog_recover_process_iunlinks()
Date: Fri, 16 Mar 2012 09:07:01 +1100 [thread overview]
Message-ID: <20120315220701.GN5091@dastard> (raw)
In-Reply-To: <20120315090800.GA2887@infradead.org>
On Thu, Mar 15, 2012 at 05:08:00AM -0400, Christoph Hellwig wrote:
> > + xfs_buf_hold(agibp);
> > + xfs_buf_relse(agibp);
>
> This is a very awkward way to write
>
> xfs_buf_unlock(agibp);
/me slaps forehead.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-03-15 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 8:55 [PATCH v2] xfs: Fix oops on IO error during xlog_recover_process_iunlinks() Jan Kara
2012-03-15 9:08 ` Christoph Hellwig
2012-03-15 9:19 ` Jan Kara
2012-03-15 22:07 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315220701.GN5091@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=elder@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=stable@kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox