From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q2LNKXCV140142 for ; Wed, 21 Mar 2012 18:20:33 -0500 Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id 6Rhl4uQD24HQc1iG for ; Wed, 21 Mar 2012 16:20:31 -0700 (PDT) Date: Thu, 22 Mar 2012 10:20:29 +1100 From: Dave Chinner Subject: Re: [PATCH 2/4] xfs: remove log item from AIL in xfs_iflush after a shutdown Message-ID: <20120321232029.GZ5091@dastard> References: <20120316175541.258282540@bombadil.infradead.org> <20120316175636.187265302@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120316175636.187265302@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Fri, Mar 16, 2012 at 01:55:43PM -0400, Christoph Hellwig wrote: > If a filesystem has been forced shutdown we are never going to write inodes > to disk, which means the inode items will stay in the AIL until we free > the inode. Currently that is not a problem, but a pending change requires us > to empty the AIL before shutting down the filesystem. In that case leaving > the inode in the AIL is lethal. Make sure to remove the log item from the AIL > to allow emptying the AIL on shutdown filesystems. > > Signed-off-by: Christoph Hellwig Looks OK, but I'm just not sure that all the necessary places to remove the inode from the AIL have been found. How did you find them, and how can we validate them? Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs