From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/8] xfs: initialise xfssync work before running quotachecks
Date: Thu, 22 Mar 2012 10:15:48 -0500 [thread overview]
Message-ID: <20120322151548.GS7762@sgi.com> (raw)
In-Reply-To: <1332393313-1955-4-git-send-email-david@fromorbit.com>
On Thu, Mar 22, 2012 at 04:15:08PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Because the mount process can run a quotacheck and consume lots of
> inodes, we need to be able to run periodic inode reclaim during the
> mount process. This will prevent running the system out of memory
> during quota checks.
>
> This essentially reverts 2bcf6e97, but that is safe to do now that
> the quota sync code that was causing problems during long quotacheck
> executions is now gone.
Dave, I've held off on #s 3 and 4 because they appear to be racy. Being
able to run inode reclaim during quota check seems like a good idea
though.
-Ben
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_super.c | 17 +++++++++--------
> 1 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 2c3cc2e..a08c56d 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1346,31 +1346,33 @@ xfs_fs_fill_super(
> sb->s_time_gran = 1;
> set_posix_acl_flag(sb);
>
> - error = xfs_mountfs(mp);
> + error = xfs_syncd_init(mp);
> if (error)
> goto out_filestream_unmount;
>
> - error = xfs_syncd_init(mp);
> + error = xfs_mountfs(mp);
> if (error)
> - goto out_unmount;
> + goto out_syncd_stop;
>
> root = igrab(VFS_I(mp->m_rootip));
> if (!root) {
> error = ENOENT;
> - goto out_syncd_stop;
> + goto out_unmount;
> }
> if (is_bad_inode(root)) {
> error = EINVAL;
> - goto out_syncd_stop;
> + goto out_unmount;
> }
> sb->s_root = d_make_root(root);
> if (!sb->s_root) {
> error = ENOMEM;
> - goto out_syncd_stop;
> + goto out_unmount;
> }
>
> return 0;
>
> + out_syncd_stop:
> + xfs_syncd_stop(mp);
> out_filestream_unmount:
> xfs_filestream_unmount(mp);
> out_free_sb:
> @@ -1387,8 +1389,6 @@ out_destroy_workqueues:
> out:
> return -error;
>
> - out_syncd_stop:
> - xfs_syncd_stop(mp);
> out_unmount:
> /*
> * Blow away any referenced inode in the filestreams cache.
> @@ -1400,6 +1400,7 @@ out_destroy_workqueues:
> xfs_flush_buftarg(mp->m_ddev_targp, 1);
>
> xfs_unmountfs(mp);
> + xfs_syncd_stop(mp);
> goto out_free_sb;
> }
>
> --
> 1.7.9
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-22 15:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 5:15 [PATH 0/8] xfs: outstanding patches for 3.4 merge window Dave Chinner
2012-03-22 5:15 ` [PATCH 1/8] xfs: Fix open flag handling in open_by_handle code Dave Chinner
2012-03-22 5:15 ` [PATCH 2/8] xfs: introduce an allocation workqueue Dave Chinner
2012-03-22 5:15 ` [PATCH 3/8] xfs: initialise xfssync work before running quotachecks Dave Chinner
2012-03-22 15:15 ` Ben Myers [this message]
2012-03-22 21:07 ` Dave Chinner
2012-03-23 13:34 ` Mark Tinguely
2012-03-25 23:22 ` Dave Chinner
2012-03-26 15:10 ` Mark Tinguely
2012-03-26 21:57 ` Dave Chinner
2012-03-28 19:40 ` Ben Myers
2012-03-29 0:29 ` Dave Chinner
2012-03-29 6:30 ` [PATCH v2] xfs: Ensure inode reclaim can run during quotacheck Dave Chinner
2012-03-28 17:38 ` [PATCH 3/8] xfs: initialise xfssync work before running quotachecks Ben Myers
2012-03-28 18:02 ` Christoph Hellwig
2012-03-28 18:43 ` Ben Myers
2012-03-22 5:15 ` [PATCH 4/8] xfs: remove MS_ACTIVE guard from inode reclaim work Dave Chinner
2012-03-22 5:15 ` [PATCH 5/8] xfs: don't cache inodes read through bulkstat Dave Chinner
2012-03-22 5:15 ` [PATCH 6/8] xfs: Account log unmount transaction correctly Dave Chinner
2012-03-24 8:27 ` Christoph Hellwig
2012-03-24 22:49 ` Dave Chinner
2012-03-26 22:28 ` Ben Myers
2012-03-22 5:15 ` [PATCH 7/8] xfs: fix fstrim offset calculations Dave Chinner
2012-03-24 13:36 ` Christoph Hellwig
2012-03-27 20:48 ` Ben Myers
2012-03-27 21:42 ` Dave Chinner
2012-03-22 5:15 ` [PATCH 8/8] xfs: add lots of attribute trace points Dave Chinner
2012-03-24 13:42 ` Christoph Hellwig
2012-03-27 21:18 ` Ben Myers
2012-03-27 21:45 ` Dave Chinner
2012-03-27 22:01 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322151548.GS7762@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox