public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Kamal Dasu <kdasu.kdev@gmail.com>
Cc: cernekee@gmail.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix deadlock in xfs_rtfree_extent with kernel v3.x
Date: Thu, 22 Mar 2012 14:59:43 -0500	[thread overview]
Message-ID: <20120322195943.GT7762@sgi.com> (raw)
In-Reply-To: <1329957699-20769-1-git-send-email-kdasu.kdev@gmail.com>

On Wed, Feb 22, 2012 at 07:41:39PM -0500, Kamal Dasu wrote:
> To fix the deadlock caused by recursively calling xfs_rtfree_extent
> 
>  - removed xfs_ilock() and xfs_trans_ijoin() from xfs_rtfree_extent(),
>    instead added asserts that the inode is locked and has an inode_item
>    attached to it.
>  - in xfs_bunmapi() when dealing with an inode with the rt flag
>    call xfs_ilock() and xfs_trans_ijoin() so that the
>    reference count is bumped on the inode and attached it to the
>    transaction before calling into xfs_bmap_del_extent, similar to
>    what we do in xfs_bmap_rtalloc.
> 
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>

Kamal, this looks good to me.
Reviewed-by: Ben Myers <bpm@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      parent reply	other threads:[~2012-03-22 19:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23  0:41 [PATCH] xfs: fix deadlock in xfs_rtfree_extent with kernel v3.x Kamal Dasu
2012-02-28 16:03 ` Kamal Dasu
2012-03-22 19:59 ` Ben Myers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120322195943.GT7762@sgi.com \
    --to=bpm@sgi.com \
    --cc=cernekee@gmail.com \
    --cc=kdasu.kdev@gmail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox