From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: avoid shutdown hang in xlog_wait()
Date: Sun, 25 Mar 2012 07:28:01 -0400 [thread overview]
Message-ID: <20120325112801.GA7157@infradead.org> (raw)
In-Reply-To: <20120324224648.GF5091@dastard>
On Sun, Mar 25, 2012 at 09:46:49AM +1100, Dave Chinner wrote:
> > Looks good. I wonder if it might be simple to simply pass a flags
> > argument to xfs_ail_delete(_bulk) which tells which kind of shutdown
> > to do.
>
> I thought about doing that, but it seems strange and unusual to tell
> code how to handle errors internally instead of returning the error
> and letting the caller handle it...
>
> I don't mind either way, though. If you prefer I pass in the
> shutdown flag, I can change it all to do that....
I don't have a strong opinion. Moving the shutdown to the caller is
cleaner for sure, but it's a lot of churn when the other version would
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-25 11:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 1:47 [PATCH 0/2] xfs: fix a class of shutdown hangs Dave Chinner
2012-03-23 1:47 ` [PATCH 1/2] xfs: move shutdown out of xfs_trans_ail_delete_bulk Dave Chinner
2012-03-24 17:01 ` Christoph Hellwig
2012-03-23 1:47 ` [PATCH 2/2] xfs: avoid shutdown hang in xlog_wait() Dave Chinner
2012-03-24 17:03 ` Christoph Hellwig
2012-03-24 22:46 ` Dave Chinner
2012-03-25 11:28 ` Christoph Hellwig [this message]
2012-03-27 9:45 ` [PATCH v2] shutdown hang fix (was Re: [PATCH 2/2] xfs: avoid shutdown hang in xlog_wait()) Dave Chinner
2012-03-27 9:57 ` Christoph Hellwig
2012-04-06 17:42 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120325112801.GA7157@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox